mrlan
/
EnglishPal
4
0
Fork 11
Code Issues Pull Requests 22 Projects Releases Wiki Activity

Bug518-Esther #141

Closed
mponeja wants to merge 10 commits from Bug518-Esther into Alpha-snapshot20240618
pull from: Bug518-Esther
merge into: mrlan:Alpha-snapshot20240618
Conversation 1 Commits 10 Files Changed 11
mponeja commented 2024-06-10 16:59:13 +08:00
There is no content yet.
mponeja added 160 commits 2024-06-10 16:59:14 +08:00
a0ddf4bdad 上传文件至 'app/static/js' 
修复了 Bug492 选中问号出现多个问号的问题。
解决了选中紧跟标点符号的单词，单词能正常显示。
优化了选中较长的文章时页面容易出现卡顿的问题。
dca76969eb 解决程序源文件更新了，但是 docker container 中的程序源文件没有更新的问题 
问题出在 build.sh 中的 --mount type=volume,src=englishpal-db,target=/app 。
运行 docker container 时，会将整个 englishpal-db 对应的文件夹 /var/lib/docker/volumes/englishpal-db/_data
下面的内容拷贝到  docker container 里面的 /app 文件夹下面。

然而，/var/lib/docker/volumes/englishpal-db/_data 下面的源程序文件并不是最新的（比如其 main.py 是 7月17日的）。
将 target=/app 改为 target=/app/db。即可解决问题。
1b211f107d Speed up loading next article 
The key change is replacing "d1 = load_freq_history(path_prefix + 'static/frequency/ferquency.p)" with "d1 = load_freq_history(user_word_list)"
in function get_today_article() from Article.py.  Now, with a user_word_list of size about 500, the next article can be loaded within 100ms.
The new d1 is much smaller than the old one, therefore the following computation "d3 = get_difficulty_level_for_user(d1, d2)" is much faster.
The students did not feel that loading next article is slow; this is because their frequency.p is quite small.

Also log information in app/log.txt
b8222c951b revert 4120e7e54b 
revert Fix bug 551
23f0dfd8ca 更新 app/test/test_bug551_DingZeYu.py 
我这边好像没有helper文件所以我直接判断有没有这个账号，如果没有就注册一个来进行测试。这样子可以吗
90ac789bb4 Merge remote-tracking branch 'origin/Bug545-HuangHuiLing' into Bug545-HuangHuiLing 
# Conflicts:
#	app/static/js/fillword.js
#	app/static/js/highlight.js
97ddee0ccf 上传文件至test 
之前的pytest文件上传位置错误，现在更改上传到test文件夹中
mponeja added 1 commit 2024-06-10 18:20:54 +08:00
mrlan commented 2024-06-11 08:41:30 +08:00
Owner

@mponeja

Your pull request includes way too many changes (see below). Could you just show the changes you have made from the latest Alpha-snapshot20230621 branch?

Check our course home page for the Git commands you need. For example,

  • Git commands that you must know

  • First sync, then push

45 changed files
with
984 additions
and
420 deletions
@mponeja Your pull request includes way too many changes (see below). Could you just show the changes you have made from the latest Alpha-snapshot20230621 branch? Check our course home page for the Git commands you need. For example, - Git commands that you must know - First sync, then push ``` 45 changed files with 984 additions and 420 deletions ```
mrlan changed title from Bug518-Esther to Bug518-Esther 2024-09-03 11:26:30 +08:00
mrlan changed target branch from Alpha-snapshot20230621 to Alpha-snapshot20240618 2024-09-03 11:26:31 +08:00
mrlan closed this pull request 2024-09-03 11:44:48 +08:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/EnglishPal#141
There is no content yet.
Delete Branch "Bug518-Esther"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?