Bug545-HuangHuiLing #122

Merged
huanghuiling merged 18 commits from Bug545-HuangHuiLing into Alpha-snapshot20230621 2024-05-28 13:36:01 +08:00
There is no content yet.
huanghuiling closed this pull request 2024-05-20 15:19:19 +08:00
huanghuiling reopened this pull request 2024-05-20 15:19:22 +08:00
huanghuiling added 3 commits 2024-05-20 15:31:05 +08:00
huanghuiling changed title from WIP:Bug545-HuangHuiLing to Bug545-HuangHuiLing 2024-05-20 15:33:08 +08:00
huanghuiling added 1 commit 2024-05-21 20:00:39 +08:00
huanghuiling added 1 commit 2024-05-21 20:02:10 +08:00
huanghuiling closed this pull request 2024-05-21 20:02:22 +08:00
huanghuiling reopened this pull request 2024-05-21 20:02:24 +08:00
huanghuiling added 2 commits 2024-05-21 20:35:43 +08:00
mrlan reviewed 2024-05-23 16:02:53 +08:00
@ -1,6 +1,5 @@
// initialize from localStorage
let isRead = localStorage.getItem('readChecked') !== 'false'; // default to true

@huanghuiling

删除 localStorage 可能会导致 Tang Xinyuan 组对 Bug 544 修复失效。
请验证一下,运行一下测试脚本 app/test/test_bug544_tangxinyuan.py

@huanghuiling 删除 localStorage 可能会导致 Tang Xinyuan 组对 Bug 544 修复失效。 请验证一下,运行一下测试脚本 app/test/test_bug544_tangxinyuan.py

老师,运行后显示测试通过

老师,运行后显示测试通过

我将它添加回去后,再次测试也是通过的

我将它添加回去后,再次测试也是通过的

image

![image](/attachments/562abd5f-a732-44d6-a47b-4c5f77a2c830)
huanghuiling added 1 commit 2024-05-25 11:59:45 +08:00
huanghuiling added 1 commit 2024-05-25 12:03:43 +08:00
mrlan reviewed 2024-05-25 14:05:51 +08:00
@ -0,0 +9,4 @@
from helper import signup
def has_punctuation(s):

@huanghuiling

函数 has_punctuation 没有被用到,请删除。

@huanghuiling 函数 has_punctuation 没有被用到,请删除。
mrlan reviewed 2024-05-25 14:07:02 +08:00
@ -0,0 +26,4 @@
# 假设我们想要选择从第10个字符开始的5个字符
actions.click()
actions.perform()
time.sleep(5)

@huanghuiling

time.sleep 可以调到 1 秒吗?

@huanghuiling time.sleep 可以调到 1 秒吗?
mrlan reviewed 2024-05-25 14:07:07 +08:00
@ -0,0 +62,4 @@
assert selected_words != "","选中单词被放置框中"
#再次选取
select(driver)
time.sleep(6)

@huanghuiling

time.sleep 可以调到 1 秒吗?

@huanghuiling time.sleep 可以调到 1 秒吗?

可以的

可以的
huanghuiling added 1 commit 2024-05-25 15:14:38 +08:00
huanghuiling added 1 commit 2024-05-25 15:20:38 +08:00
huanghuiling added 1 commit 2024-05-25 15:24:56 +08:00

@huanghuiling

修改后测试失败了。

为什么要删除 assert selected_words != "","选中单词被放置框中"

@huanghuiling 修改后测试失败了。 为什么要删除 `assert selected_words != "","选中单词被放置框中"` ?

因为用鼠标模拟去选择单词的时候,我为了保证选择的单词是一样的,用了双击去选择,但是会选择到空格,所以把这个删掉了。

因为用鼠标模拟去选择单词的时候,我为了保证选择的单词是一样的,用了双击去选择,但是会选择到空格,所以把这个删掉了。

老师,因为为了保证选择的单词一样,我是用标题测试的,我发现如果选择标题的首字母是大写的单词是有问题的,所以会测试错误,我去修改一下。

老师,因为为了保证选择的单词一样,我是用标题测试的,我发现如果选择标题的首字母是大写的单词是有问题的,所以会测试错误,我去修改一下。
huanghuiling added 1 commit 2024-05-26 11:19:39 +08:00
huanghuiling added 1 commit 2024-05-26 11:22:54 +08:00
huanghuiling added 1 commit 2024-05-26 11:27:22 +08:00
huanghuiling added 1 commit 2024-05-26 11:32:50 +08:00

蓝老师,不知道为什么,我用未经我修改的代码去测试dingzeyu小组,也是显示的测试失败

蓝老师,不知道为什么,我用未经我修改的代码去测试dingzeyu小组,也是显示的测试失败

image

![image](/attachments/1d7df84b-5b0d-47a0-b6d0-5ac02b538f99)
huanghuiling added 1 commit 2024-05-27 14:27:03 +08:00
huanghuiling added 1 commit 2024-05-27 14:36:01 +08:00

@huanghuiling

APPROVED

@huanghuiling APPROVED
huanghuiling merged commit d8af2a7e54 into Alpha-snapshot20230621 2024-05-28 13:36:01 +08:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/EnglishPal#122
There is no content yet.