mrlan
/
LRR
3
0
Fork 2
Code Issues Pull Requests 7 Projects Releases Wiki Activity

Fix Bug 430 #63

Merged
mrlan merged 4 commits from Bug430-Eden into Hui-Organize 2024-09-15 16:04:00 +08:00
Conversation 6 Commits 4 Files Changed 3
eden commented 2023-12-27 03:12:44 +08:00
Collaborator

Hello teacher, please check my request.

Hello teacher, please check my request.
eden added 1 commit 2023-12-27 03:12:45 +08:00
mrlan reviewed 2023-12-27 07:55:43 +08:00
Script.php Outdated
@ -118,1 +134,4 @@
. "('$email','$password_hash','$fullname','Student','$student_id')";
$_SESSION['user_fullname'] =$_SESSION['user_fullname_temp'];
mrlan commented 2023-12-27 07:55:43 +08:00
Owner

@eden
Please add a whitespace after =.

@eden Please add a whitespace after `=`.
eden marked this conversation as resolved
mrlan commented 2023-12-27 07:58:09 +08:00
Owner

@eden

Thanks.

Ayoub also fixed the "logged in even after failed sign-up" problem.

Could you check his solution and tell me whether your fix has overlap with his?

Ayoub's fix

@eden Thanks. Ayoub also fixed the "logged in even after failed sign-up" problem. Could you check his solution and tell me whether your fix has overlap with his? [Ayoub's fix](http://118.25.96.118:3000/mrlan/LRR/pulls/61/files)
eden commented 2023-12-31 04:30:17 +08:00
Poster
Collaborator

@eden

Thanks.

Ayoub also fixed the "logged in even after failed sign-up" problem.

Could you check his solution and tell me whether your fix has overlap with his?

Ayoub's fix

> @eden > > Thanks. > > Ayoub also fixed the "logged in even after failed sign-up" problem. > > Could you check his solution and tell me whether your fix has overlap with his? > > [Ayoub's fix](http://118.25.96.118:3000/mrlan/LRR/pulls/61/files) >
eden commented 2023-12-31 04:34:33 +08:00
Poster
Collaborator

Yes teacher, it does. We also managed to fix that by adding one line of code.

$_SESSION['user_fullname'] = null;

The creator of this project used this line to prevent unwanted login attempt during sign up. It has this code ($_SESSION['user_fullname'] = null;) throughout the script.php except under the strong password validation check. So, we decided to add this line to solve this problem.

Yes teacher, it does. We also managed to fix that by adding one line of code. $_SESSION['user_fullname'] = null; The creator of this project used this line to prevent unwanted login attempt during sign up. It has this code ($_SESSION['user_fullname'] = null;) throughout the script.php except under the strong password validation check. So, we decided to add this line to solve this problem.
script.PNG
96 KiB
script.PNG
mrlan commented 2024-01-08 18:30:29 +08:00
Owner

@eden

After merging Pull Request 61 to Hui-Organize, your Pull Request now has conflicts with the updated branch Hui-Organize.

This is probably because you and the author of Pull Request 61 changed the same line from the same file.

Please resolve the conflict.

Thanks,
Hui

@eden After merging [Pull Request 61](http://118.25.96.118:3000/mrlan/LRR/pulls/61) to Hui-Organize, your Pull Request now has conflicts with the updated branch Hui-Organize. This is probably because you and the author of Pull Request 61 changed the same line from the same file. Please resolve the conflict. Thanks, Hui
eden added 1 commit 2024-01-12 02:16:50 +08:00
eden commented 2024-01-12 02:19:21 +08:00
Poster
Collaborator

@mrlan hello teacher, I have completed the task.

@mrlan hello teacher, I have completed the task.
mrlan commented 2024-01-15 17:47:24 +08:00
Owner

@eden

Thanks. I will have a look.

Hui

@eden Thanks. I will have a look. Hui
mrlan reviewed 2024-01-15 18:10:28 +08:00
Script.php Outdated
@ -106,15 +119,69 @@ if (!empty($_POST["form_signup"])) {
if (!empty($_POST["form_signup"])) {
$fullname = mysqli_real_escape_string($con, $_POST["fullname"]);
$student_id = mysqli_real_escape_string($con, $_POST["user_student_id"]);
<<<<<<< HEAD
mrlan commented 2024-01-15 18:10:28 +08:00
Owner

@eden

Can the updated PHP script run with HEAD on line 122?

Hui

@eden Can the updated PHP script run with ``HEAD`` on line 122? Hui
eden commented 2024-01-22 16:43:41 +08:00
Poster
Collaborator

@mrlan

Yes, it works perfectly fine.

@mrlan Yes, it works perfectly fine.
mrlan added 2 commits 2024-09-15 16:03:22 +08:00
mrlan merged commit 5ebb0ccd6c into Hui-Organize 2024-09-15 16:04:00 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/LRR#63
There is no content yet.
Delete Branch "Bug430-Eden"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?