mrlan
/
LRR
3
0
Fork 2
Code Issues Pull Requests 7 Projects Releases Wiki Activity

WIP Refactor-Moyo #52

Open
moyo wants to merge 9 commits from Refactor-Moyo into master
pull from: Refactor-Moyo
merge into: mrlan:master
Conversation 0 Commits 9 Files Changed 15
moyo commented 2023-01-04 02:46:18 +08:00
Collaborator

Please consider this pull request

Separating CSS to reduce LOC in the code

36d739c923

Please consider this pull request Separating CSS to reduce LOC in the code http://121.4.94.30:3000/mrlan/LRR/commit/36d739c9233c8a7cff563bc4b867634285093b99
moyo added 9 commits 2023-01-04 02:46:18 +08:00
7d56b3df60 Bug 519 - Typos and grammar errors in the program 
Admin.php:
"Intial Password": "Intial" is a typo.

Courses.php:
"Dealine Date/Time": "Dealine" is a typo.

"Ttle" is a typo.
"Invidual" is a typo.

Script.php:
"sepcial" is a typo.
"Inavlid" is a typo.
"Garde" is a typo.  Should be "Grade".

Student.php:
"STUEDNT" is a typo.  Should be "Student".
deac064cf5 Bug 519 - Typos and grammar errors in the program 
Admin.php:
"Intial Password": "Intial" is a typo.

Courses.php:
"Dealine Date/Time": "Dealine" is a typo.

"Ttle" is a typo.
"Invidual" is a typo.

Script.php:
"sepcial" is a typo.
"Inavlid" is a typo.
"Garde" is a typo.  Should be "Grade".

Student.php:
"STUEDNT" is a typo.  Should be "Student".
518e1eef1a Bug 37 has been fixed for the index page as this page is now optimized and dynamic CSS has been used 
Applying DRY principles and better coding practices to index.php

Separating the CSS and applying DRY principles to the CSS in index.php so that they are all in main.css
77ebd6ac3e Bug 37 has been fixed for the index page as this page is now optimized and dynamic CSS has been used 
Applying DRY principles and better coding practices to index.php

Separating the CSS and applying DRY principles to the CSS in index.php so that they are all in main.css
1b31229fb2 Removal of inline CSS in Header.php as it is bad design and moved it to main.css to enable DRY concept 
The page header is defined in a single stylesheet so that if you want to change how a page header looks across the entire site, you change the css in one place.
b551f6269e Bug 32 CSS slowing things down 
Solution taken was to remove font-awesome from the header and replace everything and use bootstrap with performs better than font-awesome as said by
https://downtimemonkey.com/blog/how-we-boosted-page-load-speed.php
font awesome is slow
47e3eb90d1 Bug 32 CSS slowing things down 
Solution taken was to remove font-awesome from the header and replace everything and use bootstrap with performs better than font-awesome as said by
https://downtimemonkey.com/blog/how-we-boosted-page-load-speed.php
font awesome is slow
This pull request has changes conflicting with the target branch.
  • Script.php
  • Student.php
  • Admin.php
  • Courses.php
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b Refactor-Moyo master
git pull origin Refactor-Moyo

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff Refactor-Moyo
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/LRR#52
There is no content yet.
Delete Branch "Refactor-Moyo"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?