pull request from SPM-Zayid-468 , Adding Filters On Course Search #38
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "SPM-Zayid-468"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
Implemented filters for the following:
Case 1: the user has entered something under "Find course by Code".
List the courses whose course code matches the entered course code, in reverse chronological order.
Case 2: the user has not entered something under "Find course by Code".
If there is a value for "List courses by faculty", list all courses that belong to the entered faulty, in reverse chronological order.
Otherwise, list the student's joined courses (already done), in reverse chronological order.
Thanks. Please do not merge by yourself.
Hui
Sure Teacher, I accidently Merged , but I reverted the Changes I am Sorry 💯
@mrlan @zayid
LGTM, I have cloned the PR and ran it, works fine.
The comments were very helpful, thanks.
@ -554,1 +554,4 @@
$student_id= $_SESSION['user_student_id'];
// current academic year - i.e 2021 - 2022 , so we will show in search result:
// course containing either 2021 or 2022 as academic year.
$oldest_academic_year = date('Y') - 1;
@zayid
date('Y') - 1
is going to be equal to current year - 1, right?Yes , for this year that will be 2022 - 1 = 2021
Thanks. Worked.
Hui
Thanks , I am Glad it worked .