pull request from SPM-Zayid-468 , Adding Filters On Course Search #38

Merged
mrlan merged 1 commits from SPM-Zayid-468 into master 2022-06-17 22:22:57 +08:00

Implemented filters for the following:
Case 1: the user has entered something under "Find course by Code".
List the courses whose course code matches the entered course code, in reverse chronological order.

Case 2: the user has not entered something under "Find course by Code".
If there is a value for "List courses by faculty", list all courses that belong to the entered faulty, in reverse chronological order.

Otherwise, list the student's joined courses (already done), in reverse chronological order.

Implemented filters for the following: Case 1: the user has entered something under "Find course by Code". List the courses whose course code matches the entered course code, in reverse chronological order. Case 2: the user has not entered something under "Find course by Code". If there is a value for "List courses by faculty", list all courses that belong to the entered faulty, in reverse chronological order. Otherwise, list the student's joined courses (already done), in reverse chronological order.
zayid added 1 commit 2022-06-11 15:09:32 +08:00
bd8062502b show current academic courses and order them
Implemented filters for the following:
Case 1: the user has entered something under "Find course by Code".
List the courses whose course code matches the entered course code, in reverse chronological order.

Case 2: the user has not entered something under "Find course by Code".
If there is a value for "List courses by faculty", list all courses that belong to the entered faulty, in reverse chronological order.

Otherwise, list the student's joined courses (already done), in reverse chronological order.

Thanks. Please do not merge by yourself.

Hui

Thanks. Please do not merge by yourself. Hui

Sure Teacher, I accidently Merged , but I reverted the Changes I am Sorry 💯

Sure Teacher, I accidently Merged , but I reverted the Changes I am Sorry 💯
Ibrahim approved these changes 2022-06-13 12:26:54 +08:00
Ibrahim left a comment

@mrlan @zayid

LGTM, I have cloned the PR and ran it, works fine.

The comments were very helpful, thanks.

@mrlan @zayid LGTM, I have cloned the PR and ran it, works fine. The comments were very helpful, thanks.
@ -554,1 +554,4 @@
$student_id= $_SESSION['user_student_id'];
// current academic year - i.e 2021 - 2022 , so we will show in search result:
// course containing either 2021 or 2022 as academic year.
$oldest_academic_year = date('Y') - 1;

@zayid

date('Y') - 1 is going to be equal to current year - 1, right?

@zayid `date('Y') - 1` is going to be equal to current year - 1, right?

Yes , for this year that will be 2022 - 1 = 2021

Yes , for this year that will be 2022 - 1 = 2021

Thanks. Worked.

Hui

Thanks. Worked. Hui
mrlan merged commit b0f1f313d6 into master 2022-06-17 22:22:57 +08:00

Thanks , I am Glad it worked .

Thanks , I am Glad it worked .
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/LRR#38
There is no content yet.