mrlan
/
LRR
4
0
Fork 2
Code Issues Pull Requests 7 Projects Releases Wiki Activity

BUG23 FIXED #37

Merged
mrlan merged 6 commits from Bug23-Haji into master 2022-06-17 22:12:52 +08:00
Conversation 6 Commits 6 Files Changed 3
yaaqob commented 2022-05-26 10:33:55 +08:00

Please review the code, the bug 23 is fixed

Please review the code, the [bug 23](http://118.25.96.118/bugzilla/show_bug.cgi?id=23) is fixed
yaaqob added 1 commit 2022-05-26 10:33:55 +08:00
yaaqob changed title from BUG22 FIXED to BUG23 FIXED 2022-05-26 10:56:51 +08:00
mrlan commented 2022-05-26 22:04:07 +08:00
Owner

Thanks. Please do not merge.

@Golden will look at your changes.

Hui

Thanks. Please do not merge. @Golden will look at your changes. Hui
yaaqob added 1 commit 2022-05-28 11:02:51 +08:00
Golden commented 2022-05-28 11:57:47 +08:00

I have checked and tested your changes. The bugfix works.

Provide the link to this pull request on your Kanboard card.

Thanks

Golden

I have checked and tested your changes. The bugfix works. Provide the link to this pull request on your Kanboard card. Thanks Golden
mrlan reviewed 2022-06-01 15:26:52 +08:00
Header.php Outdated
@ -24,1 +24,4 @@
<link href="./css/bootstrap.min.css" rel="stylesheet" type="text/css" />
<!-- *this css file can be used across all the websites
and any new css class can be added there.
* the reason is was made was to make the code reusable.
mrlan commented 2022-06-01 15:26:52 +08:00
Owner

@yaaqob

Thanks. Please improve the comment.

"is was made"?

-Hui

@yaaqob Thanks. Please improve the comment. "is was made"? -Hui
mrlan reviewed 2022-06-01 15:27:22 +08:00
Submissions.php Outdated
@ -264,3 +264,2 @@
}
echo " <k href='#'> <div class='btn btn-default break-word' style='dislay:block; word-wrap: break-word; border: 1px solid #F0F0F0;border-left: 4px solid #03407B;'>
$title <br> by : <b> $submitted_by &nbsp; &nbsp;&nbsp;&nbsp;&nbsp; [ Marked $Marks ] </b> &nbsp; Visibility : <b>$Visibility </b> <button class='btn-sm btn-success' style='margin-left:50px;' onclick='updatev($Submission_ID)'>Update visibility</button>
// you will notic why i used span here to wrap the submitted by name
mrlan commented 2022-06-01 15:27:22 +08:00
Owner

@yaaqob

"notic"?

-Hui

@yaaqob "notic"? -Hui
mrlan reviewed 2022-06-01 15:29:11 +08:00
css/main.css Outdated
@ -0,0 +1,10 @@
/* this css class is used to enable copying in texts with the mouse. */
mrlan commented 2022-06-01 15:29:11 +08:00
Owner

@yaaqob

I think "text" is not countable. Do we say "texts"?

Hui

@yaaqob I think "text" is not countable. Do we say "texts"? Hui
yaaqob added 1 commit 2022-06-03 09:11:14 +08:00
yaaqob added 1 commit 2022-06-03 09:19:38 +08:00
yaaqob commented 2022-06-03 09:26:22 +08:00
Poster

All have been fixed as you asked. Thanks

-Haji

All have been fixed as you asked. Thanks -Haji
mrlan reviewed 2022-06-03 13:29:29 +08:00
Header.php Outdated
@ -24,1 +24,4 @@
<link href="./css/bootstrap.min.css" rel="stylesheet" type="text/css" />
<!-- *this css file can be used across all the websites
and any new css class can be added there.
* The reason is used was to make the code reusable.
mrlan commented 2022-06-03 13:29:29 +08:00
Owner

@yaaqob

Thanks for your correction. But I think it is still not quite correct.

Please use "The reason is to make the css code reusable." Simpler.

Hui

@yaaqob Thanks for your correction. But I think it is still not quite correct. Please use "The reason is to make the css code reusable." Simpler. Hui
yaaqob commented 2022-06-06 17:37:41 +08:00
Poster

ok.

ok.
yaaqob added 1 commit 2022-06-06 17:42:09 +08:00
yaaqob commented 2022-06-06 17:43:12 +08:00
Poster

The changes were applied as per your request.

The changes were applied as per your request.
mrlan commented 2022-06-06 22:33:46 +08:00
Owner

Thanks Yaaqob. Your code reviewer will merge your changes if he thinks OK.

-Hui

Thanks Yaaqob. Your code reviewer will merge your changes if he thinks OK. -Hui
yaaqob added 1 commit 2022-06-09 19:48:25 +08:00
mrlan commented 2022-06-17 22:12:38 +08:00
Owner

Thanks. I checked. It worked. So I merged this branch to master on behalf of Golden.

-Hui

Thanks. I checked. It worked. So I merged this branch to master on behalf of Golden. -Hui
mrlan merged commit f0109db692 into master 2022-06-17 22:12:52 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/LRR#37
There is no content yet.
Delete Branch "Bug23-Haji"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?