mrlan
/
LRR
3
0
Fork 2
Code Issues Pull Requests 7 Projects Releases Wiki Activity

Create a test script to automate newly signup students searching for a course #32

Open
Golden wants to merge 1 commits from AutoTesting-Golden into master
pull from: AutoTesting-Golden
merge into: mrlan:master
Conversation 3 Commits 1 Files Changed 3
Golden commented 2021-12-26 17:13:08 +08:00

This pull request is for an automated test script written for bug 312. See the kanboard card for more information about the bug and how it was fixed.

This pull request is for an automated test script written for [bug 312](http://118.25.96.118/bugzilla/show_bug.cgi?id=312). See the [kanboard card](http://118.25.96.118/kanboard/?controller=TaskViewController&action=show&task_id=1506&project_id=170) for more information about the bug and how it was fixed.
👍 1
Ibrahim was assigned by Golden 2021-12-26 17:13:08 +08:00
mrlan was assigned by Golden 2021-12-26 17:13:08 +08:00
Golden added 1 commit 2021-12-26 17:13:08 +08:00
mrlan was unassigned by Golden 2021-12-26 17:33:23 +08:00
Ibrahim was unassigned by Golden 2021-12-26 17:33:23 +08:00
Golden requested review from Ibrahim 2021-12-26 17:33:35 +08:00
Golden requested review from mrlan 2021-12-26 17:33:35 +08:00
Ibrahim commented 2021-12-27 16:11:07 +08:00

I have run the test suite on my machine as well after inspection, works fine.

LGTM.

Thanks.

I have run the test suite on my machine as well after inspection, works fine. LGTM. Thanks.
Golden commented 2021-12-27 17:24:59 +08:00
Poster

Thanks for the review.

Thanks for the review.
mrlan reviewed 2021-12-27 22:12:04 +08:00
test/SeleniumIbrahim/test_kit/utility.py
@ -136,3 +136,3 @@
submit = signup_form.find_element(By.ID, "signup_btn")
submit.click()
return 0
return driver
mrlan commented 2021-12-27 22:12:04 +08:00
Owner

@Golden @Ibrahim

Thanks, Golden. Will this change (i.e., from return 0 to return driver) break Ibrahim's tests?

Hui

@Golden @Ibrahim Thanks, Golden. Will this change (i.e., from `return 0` to `return driver`) break Ibrahim's tests? Hui
Golden commented 2022-01-02 12:06:20 +08:00
Poster

Changing the return value to driver won't break other tests. It makes the signup function a utility function that other functions can depend on (i.e. Those functions can only be executed if the signup process is successful).

Changing the return value to driver won't break other tests. It makes the signup function a utility function that other functions can depend on (i.e. Those functions can only be executed if the signup process is successful).
mrlan reviewed 2021-12-27 22:15:41 +08:00
test/SeleniumIbrahim/test_kit/test_suite.py
@ -99,1 +98,4 @@
admin.assign_TA() == cond
def test_case_17():
mrlan commented 2021-12-27 22:15:41 +08:00
Owner

@Golden

Instead of using a random string, you could use the Faker package to generate names.

Hui

@Golden Instead of using a random string, you could use the [Faker](https://pypi.org/project/Faker/) package to generate names. Hui
Golden commented 2022-01-02 12:08:06 +08:00
Poster

I agree, Faker is better.

I agree, Faker is better.
mrlan commented 2021-12-27 22:19:21 +08:00
Owner

I have run the test suite on my machine as well after inspection, works fine.

LGTM.

Thanks.

@Ibrahim

Thanks. Are you sure? The following change does not have any bad consequence?

- utility = MyUtility("http://127.0.0.1/edsa-LRR3/")
+ utility = MyUtility("http://127.0.0.1/LRR/")

Hui

> I have run the test suite on my machine as well after inspection, works fine. > > LGTM. > > Thanks. @Ibrahim Thanks. Are you sure? The following change does not have any bad consequence? ``` - utility = MyUtility("http://127.0.0.1/edsa-LRR3/") + utility = MyUtility("http://127.0.0.1/LRR/") ``` Hui
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b AutoTesting-Golden master
git pull origin AutoTesting-Golden

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff AutoTesting-Golden
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Ibrahim
mrlan
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/LRR#32
There is no content yet.
Delete Branch "AutoTesting-Golden"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?