Fix Bug 557 #61

mrlan · 2023-12-23T17:19:19+08:00

mrlan commented

2023-12-23 17:19:19 +08:00

Create the pull request on behalf of Ayoub

mrlan added 153 commits 2023-12-23 17:19:20 +08:00

e455355da1 Remove redundant css link

9424794cb3 Move <style> to <head>, and make a meaningful page title.

760a80b461 Indent main.css.

830001e72d Make Header.php look better.

a975dc638c Move <style> in index.php to Header.php

5b8745cfe5 Update footer

f81b98e6aa Indent code with Emacs web-mode

24ed22e5b8 Make index.php look better

443d76b639 Make Header.php look better

346fb348c7 Move css class .form-control from Courses.php to Header.php

197437f6a1 Make Courses.php look better

975cdfec63 Review & revise the files under directory doc/

a56b4c00dd (1) Make php files look better; (2) Removed Visitors.php and Reset_password.php because they are no longer used; (3) TODO: review Submissions.php, Script.php, Course.php and Courses.php.

02da71b130 Make Submissions.php look better.

58758be824 Remove **scratch**

a1707314f5 Script.php: add the enclosing ?> for PHP code.

7ed74390ce Better JavaScript function name.

7f870d8c7a Make Course.php look better.

6b8f97dc58 Better JavaScript function name.

122bd27e80 Better indented JavaScript code.

4f7cda823b Make Courses.php look better.

a758c5a2c6 Do not track .DS_Store

020d7a2c04 Delte mail_spam.html because it is not used.

68f9db8e1d Make PHP having UTF-8 encoding.

a485c4eaf1 README.md: Add a section on solving the character-coding problem in the MySQL dump file.

dd0fc3a005 README.md: create database before import

954006ff0b Make a student's Course Page look better. The first letter in a button name is uppercase, others are in lowercase.

6be0908210 Make pages look better. List courses in descending order creation.

da6ffcf306 If a user has already logged in, he will not see the login page again after he clicks the LRR logo.

05303096e1 CSS tweaks.

732a22b9c1 Use Bootstrap's default primary button style - that one looks nicer.

890083d159 Use better form information.

0a677fa9d3 Use abetter form title.

c490974dd7 Better look.

6a4f44df73 Better information display for the student's assignment status.

e74c018a8c Remove Footer.php because it is not useful.

7d28f987d2 Make pages look even better.

9c529e0022 Upgrade to Bootstrap 5. TODO: nav tab does not work in Admin.php.

0e4a49fb3d Make nav tabs work, and make buttons look better.

6af2d77912 Add non-sticky footer.

a4a413f700 Use card class while displaying assignments in New and Marked tabs.

89395dbb98 Make student's interface look better.

498f5549df Make index page, sign up page and recover password page look better.

2fa24bba94 Use default col-md-4 from Bootstrap 5.

380c79fd8a Indent Courses.php using Emacs web-mode.

a5d90e5c50 Courses.php: seperate form from php.

fc6a1d0223 Simplify page title.

a7a33e1400 Remove unused CSS class definitions. Make spacing better.

965540c522 Remove unused CSS class definitions.

632ee82e7b Use Bootstrap's card class to make things look better.

590661d02b Make the 'New assignment' page look better.

debd5a124e Update jquery and jquery-ui.

0bcb687cb3 Revise info message.

90f8e7b835 Solve the no X problem in modal dialogue.

6a840566d2 Solve the no X problem in modal dialogue (complete it).

1c4acbf31b Better code indentation. Better style for listings.

2284e78179 Admin.php: Improve tab 'Create instructor account'.

87d5c51e9b Admin.php: move the position of including Footer.php.

2aefceedee Admin.php: remove superfluous DIV tags.

d1d37f46e4 Admin.php: better spacing.

ec0d73db52 Admin.php: better spacing.

12239d9a29 Admin.php: remove superfluous if statement.

93ba7d4389 Admin.php: remove superfluous if statement.

c3183773ea Admin.php: remove superfluous whitespaces before comma.

6309a32a07 Admin.php: SQL statement in one line.

48cff9c8d9 Admin.php: remove dash before TA name (if any). If no TA is available, show 'None' instead of leaving it empty.

aed70f3056 Admin.php: fix a bug that prevents Lecturer from blocking/activating a TA

eef84ab25f Admin.php: show Admin link icon for Admin user.

11a35b326d Header.php: do not show 'My courses' for Admin.

44f478107f Admin.php: Admin user can see all courses.

5ba25e7294 Header.php: show user name in bold face.

0bf58fc282 Course.php: give the code better format; show None if there is no attachment.

e41311dde9 Course.php: indent buffer using web-mode.

3270817a4b Course.php: remove link under Courses.

027c4fada6 Course.php: better code spacing.

1875028472 Course.php: delete unused code.

b477edca1b Course.php: better spacing; removed unused code: echo '<ul>';

f2dfb5ddd6 Course.php: make group invitation work.

97b682fdfb Course.php: better spacing.

587474e074 Course.php: better variable name .

6b1d41a02d Course.php: better variable name .

28617c9854 Course.php: better variable name .

baf2d831ef Course.php: better paragraphs.

117cc0431c Submissions.php: improve code readability.

965d78c0c6 Script.php: improve notification message.

eef551c2fb Submissions.php: improve assignment appearance.

44cd46451b Submissions.php: format code and make the appearance better.

89f69a1692 Submissions.php: change left border size and color.

32b1e81500 Submissions.php: format code.

5ac8062175 Submissions.php: better display course groups.

1b8e2bc76d Submissions.php: ignore cases where Student_ID is empty.

24af391961 Submissions.php: show group count.

6200d6ab00 Submissions.php: simplify code logic.

24131d3500 Submissions.php: more space above Total submissions.

ad32a71cd9 Submissions.php: better highlighting.

a2f2c9c30f Submissions.php: better code format.

73273d75b9 Submissions.php: better code format.

4f7cf62a24 Course.php: better code format.

53cdccf8d7 Course.php: more space under tab and change message color to yellow.

26bf3ec359 Course.php: better indent SQL statement.

d0781cde08 Course.php: better indent HTML code.

a7aa3a103d Course.php: better indent SQL statement.

7282d80ce4 Course.php: use yellow as the color for the warning message.

c1aee1e457 Course.php: remove '`'.

623634ba30 Course.php: better spacing around the '=' or '!=' operator.

de56d4bd6f Course.php: better DIV indentation.

84083981de Course.php: change warning message color to yellow.

0e3e5aec8d Make posting assignment attachment work.

63c4da74f8 Course.php: make downloading attachment work & indent code.

71e835f3fd Course.php: indent JavaScript code.

702f7ebb19 SubmitLab.php: make the link text and link better by showing course name and by redirecting to the correct page after clicking

faef5670db SubmitLab.php: indent code using web-mode

5ff32fae1a SubmitLab.php: make SQL statement look cleaner

16235b175a SubmitLab.php: better spacing

25a5c89248 SubmitLab.php: better spacing (2)

73f1e446cf SubmitLab.php: better SQL format

bef3f1ac39 SubmitLab.php: Group leader

64c625ae58 SubmitLab.php: improve student's tab 'Submitted'

e5d4819f7d Course.php: indent SQL statement

d8aeeaa876 SubmitLab.php: add spaces around operator '='

1c9c126f39 index.php: remove unnecessary space

59562ea497 index.php: password, not pass

ecce12e1f3 Submissions.php: format SQL statement

d6365377ef Submissions.php: rename variables

f740ed9a03 Submissions.php: rename variable

4292652e9b Submissions.php: capitalize SQL commands

6257818b86 Submissions.php: remove unused statements

593ac0219a Submissions.php: replace frm with form

8fbf0f1d1d Courses.php: indent JavaScript code

09301d84ca Courses.php: format SQL statement

39cc069301 Courses.php: format code

399ac535a5 Courses.php: format SQL statement

666ccd7260 Courses.php & Script.php: replace stdid with studentid

ae707cffca Courses.php: better spacing

6f689a2296 Courses.php: format SQL code

0e22600816 Courses.php: indent code

0895121ed0 Courses.php: indent SQL code

bc89e6c214 Courses.php: better code spacing

368c4763d2 Courses.php: variable renaming: ->

79a928354b Courses.php: better code spacing (2)

1cac6bebea Courses.php: improve search logic

54d1d5ee97 Courses.php: better code spacing (3)

aa349a8d6c Courses.php: format SQL code

5683013655 Courses.php: better spacing and better variable name (academic -> academic_year)

849009e624 Courses.php: better variable name ( -> )

33e454e3da Courses.php: better spacing

a8b235052f Courses.php: better spacing and better variable name (fname -> faculty)

d5165af308 Course.php: format code for JavaScript function invite()

4caffe4709 Course.php: format code for JavaScript function accept()

eccd584d76 Course.php: format code for JavaScript function removeMember()

8d30ecc584 Course.php: format code for JavaScript function deleteGroup()

5a82c91304 Fix Bug 557

1c560589ba Merge branch 'Bug557-Ayoub' of http://118.25.96.118:3000/mrlan/LRR into Bug557-Ayoub

mrlan changed title from ~~Fix Bug 557~~ to Fix Bug 557

2023-12-23 18:25:57 +08:00

mrlan changed target branch from master to Hui-Organize

2023-12-23 18:25:58 +08:00

mrlan commented

2023-12-23 18:27:27 +08:00

Poster

@ayoub

Thanks, Ayoub. I verified that your bug fix is successful.

Hui

@ayoub Thanks, Ayoub. I verified that your bug fix is successful. Hui

mrlan merged commit fde44f7600 into Hui-Organize

2024-01-08 18:25:38 +08:00

mrlan referenced this issue from a commit

2024-01-08 18:25:40 +08:00

Merge pull request 'Fix Bug 557' (#61) from Bug557-Ayoub into Hui-Organize

~~mrlan referenced this pull request 2024-01-08 18:29:28 +08:00~~

Bug430-Eden2 #62

mrlan referenced this pull request

2024-01-08 18:30:29 +08:00

Fix Bug 430 #63

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/LRR#61