mrlan
/
EnglishPal
4
0
Fork 11
Code Issues Pull Requests 22 Projects Releases Wiki Activity

WIP: refactor-WangYu #96

Draft
yangyuchen wants to merge 4 commits from refactor-wangyu into master
pull from: refactor-wangyu
merge into: mrlan:master
Conversation 0 Commits 4 Files Changed 14
yangyuchen commented 2023-06-01 19:28:53 +08:00

重构了部分参数名以及函数名
按照Python的要求格式化了部分注释和代码，使其变得更加合理。
最新的4241cc3a6d和66772b2f8b分支为修改内容。

重构了部分参数名以及函数名 按照Python的要求格式化了部分注释和代码，使其变得更加合理。 最新的4241cc3a6d和66772b2f8b分支为修改内容。
yangyuchen added 100 commits 2023-06-01 19:28:54 +08:00
yangyuchen closed this pull request 2023-06-01 19:32:55 +08:00
yangyuchen reopened this pull request 2023-06-01 19:33:29 +08:00
wangyu added 1 commit 2023-06-01 20:56:07 +08:00
mrlan reviewed 2023-06-01 21:10:07 +08:00
app/main.py
@ -65,3 +65,3 @@
if request.method == 'POST':
d = load_freq_history(path_prefix + 'static/frequency/frequency.p')
lst_history = pickle_idea.dict2lst(d)
lst_history = pickle_idea.dict_to_lst(d)
mrlan commented 2023-06-01 21:10:07 +08:00
Owner

@yangyuchen

Thanks

dict2lst 这个不用改。 2 就是 to，发音一样。

@yangyuchen Thanks `dict2lst` 这个不用改。 `2` 就是 `to`，发音一样。
mrlan reviewed 2023-06-01 21:14:56 +08:00
app/wordfreqCMD.py
@ -38,1 +34,3 @@
return s
def file_to_str(f_name): # 文件转字符
f = open(f_name) # 打开
f_str = f.read() # 读取
mrlan commented 2023-06-01 21:14:56 +08:00
Owner

@yangyuchen

Thanks

用 s 来表示字符串， 是 Python 中典型的用法，不需要改。

类似地，用 L 来表示列表，也是可以的。

@yangyuchen Thanks 用 `s` 来表示字符串， 是 Python 中典型的用法，不需要改。 类似地，用 `L` 来表示列表，也是可以的。
mrlan reviewed 2023-06-01 21:15:55 +08:00
requirements.txt
@ -1,3 +1,5 @@
Flask==1.1.2
Flask==2.2.3
mrlan commented 2023-06-01 21:15:55 +08:00
Owner

@yangyuchen

用 Flask==1.1.2 版本即可， 2.2.3 的版本不知是否能够正常运行。

@yangyuchen 用 Flask==1.1.2 版本即可， 2.2.3 的版本不知是否能够正常运行。
This pull request has changes conflicting with the target branch.
  • app/wordfreqCMD.py
  • requirements.txt
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b refactor-wangyu master
git pull origin refactor-wangyu

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff refactor-wangyu
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/EnglishPal#96
There is no content yet.
Delete Branch "refactor-wangyu"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?