mrlan
/
EnglishPal
4
0
Fork 11
Code Issues Pull Requests 22 Projects Releases Wiki Activity

Refactor-HeZhengzheng #91

Closed
hezhengzheng wants to merge 1 commits from Refactor-HeZhengzheng into master
pull from: Refactor-HeZhengzheng
merge into: mrlan:master
Conversation 1 Commits 1 Files Changed 2
hezhengzheng commented 2023-05-24 18:45:24 +08:00

refactor:用ponyORM重构get_today_article函数的原生SQL语句

refactor:用ponyORM重构get_today_article函数的原生SQL语句
hezhengzheng added 98 commits 2023-05-24 18:45:24 +08:00
mrlan reviewed 2023-05-24 21:53:26 +08:00
app/MyPony.py
@ -0,0 +4,4 @@
# 数据库实体
class Article(db.Entity):
mrlan commented 2023-05-24 21:53:26 +08:00
Owner

@hezhengzheng

Thanks

不需要重新定义 Article(db.Entity)，在 app/model/init.py 中已经有定义。

@hezhengzheng Thanks 不需要重新定义 `Article(db.Entity)`，在 [app/model/__init__.py](https://) 中已经有定义。
mrlan reviewed 2023-05-24 21:55:48 +08:00
app/MyPony.py
@ -0,0 +21,4 @@
@db_session
def selectAllArticles():
mrlan commented 2023-05-24 21:55:48 +08:00
Owner

@hezhengzheng

  • 函数名应该符合 Python 的命名规范，比如 select_all_articles 不用驼峰法。

  • 该函数应该放到现有的 app/model/article.py 中。

@hezhengzheng - 函数名应该符合 Python 的命名规范，比如 `select_all_articles` 不用驼峰法。 - 该函数应该放到现有的 app/model/article.py 中。
mrlan reviewed 2023-05-24 21:56:14 +08:00
app/MyPony.py
@ -0,0 +39,4 @@
@db_session
def selectArticlesById(id):
mrlan commented 2023-05-24 21:56:14 +08:00
Owner

@hezhengzheng

  • 函数名应该符合 Python 的命名规范，比如 select_article_by_id 不用驼峰法。

  • 该函数应该放到现有的 app/model/article.py 中。

@hezhengzheng - 函数名应该符合 Python 的命名规范，比如 `select_article_by_id` 不用驼峰法。 - 该函数应该放到现有的 app/model/article.py 中。
mrlan commented 2023-08-12 15:30:24 +08:00
Owner

Thanks 经简化后，已经合并入 commit d2f30

Hui

Thanks 经简化后，已经合并入 commit d2f30 Hui
mrlan closed this pull request 2023-08-12 15:30:24 +08:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/EnglishPal#91
There is no content yet.
Delete Branch "Refactor-HeZhengzheng"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?