mrlan
/
EnglishPal
4
0
Fork 11
Code Issues Pull Requests 22 Projects Releases Wiki Activity

Bug499-WangZiming #60

Closed
wangziming wants to merge 9 commits from Bug499-WangZiming into master
pull from: Bug499-WangZiming
merge into: mrlan:master
Conversation 0 Commits 9 Files Changed 8
wangziming commented 2022-12-02 15:10:19 +08:00
There is no content yet.
👍 1
wangziming added 9 commits 2022-12-02 15:10:19 +08:00
mrlan changed title from WIP: Bug499-WangZiming to Bug499-WangZiming 2022-12-02 20:45:18 +08:00
mrlan reviewed 2022-12-02 21:16:01 +08:00
app/pickle_idea2.py
@ -65,2 +71,3 @@
def save_frequency_to_pickle(d, pickle_fname):
f = open(pickle_fname, 'wb')
# f = open(pickle_fname, 'wb')
f = FileOpen.write_able(pickle_fname, 'wb')
mrlan commented 2022-12-02 21:16:01 +08:00
Owner

@wangziming

Thanks

但是想得过于复杂了。目前有100个additions，22个deletions，太多了。

为了解决你们找到的Bug，在出现 f = open(pickle_fname, 'wb') 的地方的前面插入下面的语句即可:

os.makedirs(os.path.dirname(pickle_fname), exist_ok=True) # make the parent path if not existing

这样改几行即可。

不过于追求通用而失去简洁性。

不需要 FileOpen 这个类。Python 为什么不自带类似的类呢？就是为了简洁性。

少即是多。请按照我的观点更新一下这个分支。

Hui

@wangziming Thanks 但是想得过于复杂了。目前有100个additions，22个deletions，太多了。 为了解决你们找到的Bug，在出现 `f = open(pickle_fname, 'wb')` 的地方的前面插入下面的语句即可: `os.makedirs(os.path.dirname(pickle_fname), exist_ok=True) # make the parent path if not existing` 这样改几行即可。 不过于追求通用而失去简洁性。 不需要 `FileOpen` 这个类。Python 为什么不自带类似的类呢？就是为了简洁性。 少即是多。请按照我的观点更新一下这个分支。 Hui
mrlan closed this pull request 2023-07-09 16:45:35 +08:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/EnglishPal#60
There is no content yet.
Delete Branch "Bug499-WangZiming"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?