mrlan
/
EnglishPal
4
0
Fork 11
Code Issues Pull Requests 22 Projects Releases Wiki Activity

上传文件至 static js #36

Closed
tanyanmei wants to merge 16 commits from Bug393-TanYanMei into master
pull from: Bug393-TanYanMei
merge into: mrlan:master
Conversation 5 Commits 16 Files Changed 15
tanyanmei commented 2022-06-12 21:44:33 +08:00
There is no content yet.
tanyanmei added 1 commit 2022-06-12 21:44:34 +08:00
chenyifan reviewed 2022-11-29 17:01:11 +08:00
static\js/fillword.js Outdated
@ -0,0 +17,4 @@
function read(s){
var msg = new SpeechSynthesisUtterance(s);
reader.speak(msg);
console.log("+++++++++++++");
chenyifan commented 2022-11-29 17:01:11 +08:00

@mrlan

该行代码的日志添加没有实际意义，建议删除该行代码

@mrlan 该行代码的日志添加没有实际意义，建议删除该行代码
mrlan changed title from 上传文件至 'static\js' to 上传文件至 static js 2023-04-20 08:40:14 +08:00
mrlan added 2 commits 2023-04-24 11:39:04 +08:00
mrlan added 1 commit 2023-04-24 11:43:56 +08:00
nilingli added 63 commits 2023-05-09 18:06:39 +08:00
mrlan commented 2023-05-10 07:06:16 +08:00
Owner

Thanks. Please do code review.

Hui

Thanks. Please do code review. Hui
nilingli commented 2023-05-30 18:03:11 +08:00

code review
当点击"把生词加入我的生词库"时，如果正在朗读，朗读声不会停止。建议加上onclick="stopRead()"

code review 当点击"把生词加入我的生词库"时，如果正在朗读，朗读声不会停止。建议加上onclick="stopRead()"
nilingli added 43 commits 2023-05-30 18:49:13 +08:00
a0ddf4bdad 上传文件至 'app/static/js' 
修复了 Bug492 选中问号出现多个问号的问题。
解决了选中紧跟标点符号的单词，单词能正常显示。
优化了选中较长的文章时页面容易出现卡顿的问题。
nilingli commented 2023-05-30 18:50:55 +08:00

合并最新的Alpha-snapshot20230529 ，在把修改整合到一个commit里

合并最新的Alpha-snapshot20230529 ，在把修改整合到一个commit里
nilingli closed this pull request 2023-05-30 18:50:55 +08:00
nilingli reopened this pull request 2023-05-30 18:53:15 +08:00
mrlan commented 2023-05-31 09:22:00 +08:00
Owner

@nilingli

Thanks

tanyanmei-fillword.js 这个文件还有用吗？如果没用了，请删除，再更新这个 Pull Request。

Fast-forward
 app/static/js/fillword.js           |  3 +++
 app/static/js/tanyanmei-fillword.js | 33 +++++++++++++++++++++++++++++++++
 app/templates/userpage_get.html     |  6 +++---
 3 files changed, 39 insertions(+), 3 deletions(-)
 create mode 100644 app/static/js/tanyanmei-fillword.js
@nilingli Thanks tanyanmei-fillword.js 这个文件还有用吗？如果没用了，请删除，再更新这个 Pull Request。 ``` Fast-forward app/static/js/fillword.js | 3 +++ app/static/js/tanyanmei-fillword.js | 33 +++++++++++++++++++++++++++++++++ app/templates/userpage_get.html | 6 +++--- 3 files changed, 39 insertions(+), 3 deletions(-) create mode 100644 app/static/js/tanyanmei-fillword.js ```
mrlan commented 2023-05-31 09:30:47 +08:00
Owner

@nilingli

已经部署。

好像点击 “下一篇 Next Article“ 按钮后，还是会继续朗读的。请检查分支 Alpha-snapshot20230531。

@nilingli 已经部署。 好像点击 “下一篇 Next Article“ 按钮后，还是会继续朗读的。请检查分支 `Alpha-snapshot20230531`。
nilingli added 1 commit 2023-05-31 18:37:40 +08:00
nilingli added 7 commits 2023-06-04 00:40:09 +08:00
nilingli added 1 commit 2023-06-04 01:50:31 +08:00
mrlan reviewed 2023-06-04 18:53:45 +08:00
app/pickle_idea.py Outdated
@ -41,2 +40,2 @@
d = pickle.load(f)
f.close()
with open(pickle_fname, 'rb') as f:
d=pickle.load(f)
mrlan commented 2023-06-04 18:53:45 +08:00
Owner

d = pickle.load(f)

等号前后需要有空格

`d = pickle.load(f)` 等号前后需要有空格
mrlan reviewed 2023-06-04 18:55:18 +08:00
app/Article.py Outdated
@ -18,0 +12,4 @@
'''
得到文章总数
return:文章数目
'''
mrlan commented 2023-06-04 18:55:18 +08:00
Owner

这样的注释没啥意思。不能增加新的有用的信息。

函数名 total_number_of_essays 即注释，所以不需要重复注释。

这样的注释没啥意思。不能增加新的有用的信息。 函数名 `total_number_of_essays` 即注释，所以不需要重复注释。
mrlan reviewed 2023-06-04 18:56:28 +08:00
app/Login.py Outdated
@ -21,2 +19,3 @@
def verify_pass(newpass,oldpass):
if(newpass==oldpass):
'''
判断新旧密码是否相同
mrlan commented 2023-06-04 18:56:28 +08:00
Owner

这样的注释也是多余的。 因为 newpass == oldpass 已经把事情说得很清楚了。

这样的注释也是多余的。 因为 `newpass == oldpass` 已经把事情说得很清楚了。
nilingli added 1 commit 2023-06-05 21:27:36 +08:00
mrlan closed this pull request 2024-08-28 08:12:41 +08:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/EnglishPal#36
There is no content yet.
Delete Branch "Bug393-TanYanMei"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?