mrlan
/
EnglishPal
4
0
Fork 11
Code Issues Pull Requests 22 Projects Releases Wiki Activity

BugFix358 + Improve + Refactor #27

Closed
tengjiaqian wants to merge 3 commits from Bug358-TengJiaQian into master
pull from: Bug358-TengJiaQian
merge into: mrlan:master
Conversation 2 Commits 3 Files Changed 6
tengjiaqian commented 2022-06-06 19:59:43 +08:00

[BUGFIX] wordFreqCMD.py: Function 'remove_punctuation', Bug Fix 358

[IMPROVE] userpage_get.html: add a

to submit word to the analyse page
[IMPROVE] userpage_post.html: add a to remind the user which word are already in the database
[IMPROVE] user_service.py: In function 'userpage', add a new feature to analyse a single word & pass a list of words from the database to the front-end

[REFACTOR] wordFreqCMD.py: In function 'make_html_page', rename some variables and expand HTML construction code, and use the new function 'getHyperLinkHTML' to get the tag content

[BUGFIX] wordFreqCMD.py: Function 'remove_punctuation', Bug Fix 358 [IMPROVE] userpage_get.html: add a <form> to submit word to the analyse page [IMPROVE] userpage_post.html: add a <font> to remind the user which word are already in the database [IMPROVE] user_service.py: In function 'userpage', add a new feature to analyse a single word & pass a list of words from the database to the front-end [REFACTOR] wordFreqCMD.py: In function 'make_html_page', rename some variables and expand HTML construction code, and use the new function 'getHyperLinkHTML' to get the <a> tag content
tengjiaqian added 1 commit 2022-06-06 19:59:43 +08:00
mrlan commented 2022-06-06 22:34:21 +08:00
Owner

Thanks. Someone will review your code. Please do not merge by yourself.

-Hui

Thanks. Someone will review your code. Please do not merge by yourself. -Hui
mrlan reviewed 2022-06-07 21:38:26 +08:00
app/templates/analyse_word.html
@ -0,0 +8,4 @@
<body>
<div>
<br/>
<h3>单词 {{ word }} 的统计信息</h3>
mrlan commented 2022-06-07 21:38:26 +08:00
Owner

@tengjiaqian

这个跟 Bug 358 有关系吗？ 是上个学期的工作？

蓝珲

@tengjiaqian 这个跟 [Bug 358](http://118.25.96.118/bugzilla/show_bug.cgi?id=358) 有关系吗？ 是上个学期的工作？ 蓝珲
tengjiaqian commented 2022-06-11 09:58:44 +08:00
Poster

是上学期的工作

是上学期的工作
mrlan reviewed 2022-06-07 21:41:57 +08:00
app/wordfreqCMD.py Outdated
@ -85,2 +129,4 @@
f.write(result)
f.close()
def getHyperlinkHTML(word):
mrlan commented 2022-06-07 21:41:57 +08:00
Owner

@tengjiaqian

函数名改为 get_html_hyperlink。

-蓝珲

@tengjiaqian 函数名改为 `get_html_hyperlink`。 -蓝珲
tengjiaqian added 1 commit 2022-06-11 09:56:55 +08:00
tengjiaqian commented 2022-06-11 09:58:58 +08:00
Poster

已修改

已修改
tengjiaqian changed title from WIP: BugFix358 + Improve + Refactor Commit Message to BugFix358 + Improve + Refactor 2022-06-13 19:32:17 +08:00
tengjiaqian added 1 commit 2022-06-13 19:40:19 +08:00
ruanyuxuan reviewed 2022-12-13 16:38:54 +08:00
app/templates/userpage_get.html
@ -45,0 +48,4 @@
<input type="text" name="content"/><br/>
<input type="submit" value="分析此单词" style="margin-top:5px"/>
<input type="reset" value="清除"/>
</form><br/>
ruanyuxuan commented 2022-12-13 16:38:54 +08:00

这一部分内容和BUG358里的修复关系不大

这一部分内容和BUG358里的修复关系不大
ruanyuxuan reviewed 2022-12-13 16:40:29 +08:00
app/user_service.py
@ -109,0 +132,4 @@
minrate = min(minrate, 100 * cnt / tot)
return render_template('analyse_word.html', mincount=mincount, maxcount=maxcount, totcount=totcount, totcnt=totcnt,
maxrate=maxrate, minrate=minrate, resultlen=len(result),
word=word, username=session.get('username'))
ruanyuxuan commented 2022-12-13 16:40:29 +08:00

添加代码过于冗长，不够简洁

添加代码过于冗长，不够简洁
ruanyuxuan reviewed 2022-12-13 16:41:02 +08:00
app/wordfreqCMD.py
@ -28,3 +27,3 @@
def youdao_link(s): # 有道链接
link = 'http://youdao.com/w/eng/' + s + '/#keyfrom=dict2.index'# 网址
link = 'http://youdao.com/w/eng/' + s + '/#keyfrom=dict2.index' # 网址
ruanyuxuan commented 2022-12-13 16:41:02 +08:00

无意义的添加与删除

无意义的添加与删除
mrlan closed this pull request 2024-09-08 11:55:03 +08:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/EnglishPal#27
There is no content yet.
Delete Branch "Bug358-TengJiaQian"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?