mrlan
/
EnglishPal
4
0
Fork 11
Code Issues Pull Requests 22 Projects Releases Wiki Activity

i added select all function #26

Closed
yaaqob wants to merge 1 commits from bug209_yaaqobv2 into master
pull from: bug209_yaaqobv2
merge into: mrlan:master
Conversation 1 Commits 1 Files Changed 1
1 changed files with 57 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
app/templates/userpage_post.html
View File

@ -1,21 +1,20 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=0.5, maximum-scale=3.0, user-scalable=yes" />
<meta charset="UTF-8" />
<meta
name="viewport"
content="width=device-width, initial-scale=1.0, minimum-scale=0.5, maximum-scale=3.0, user-scalable=yes"
/>
mrlan commented 2022-06-07 21:31:02 +08:00
Review

@yaaqob

Thanks. What is the point of breaking the following line into several lines?

<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=0.5, maximum-scale=3.0, user-scalable=yes" />

Hui

@yaaqob Thanks. What is the point of breaking the following line into several lines? `<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=0.5, maximum-scale=3.0, user-scalable=yes" />` Hui
<meta name="format-detection" content="telephone=no" />
{{ yml['header'] | safe }}
{% if yml['css']['item'] %}
{% for css in yml['css']['item'] %}
<link href="{{ css }}" rel="stylesheet">
{% endfor %}
{% endif %}
{% if yml['js']['head'] %}
{% for js in yml['js']['head'] %}
{{ yml['header'] | safe }} {% if yml['css']['item'] %} {% for css in
yml['css']['item'] %}
<link href="{{ css }}" rel="stylesheet" />
{% endfor %} {% endif %} {% if yml['js']['head'] %} {% for js in
yml['js']['head'] %}
<script src="{{ js }}"></script>
{% endfor %}
{% endif %}
{% endfor %} {% endif %}
<title>EnglishPal Study Room for {{username}}</title>
</head>
@ -23,23 +22,43 @@
<p>勾选不认识的单词</p>
<form method="post" action="/{{username}}/mark">
<input type="submit" name="add-btn" value="加入我的生词簿" />
{% for x in lst %}
{% set word = x[0]%}
<input
onclick="checkall()"
type="button"
name="add-btn"
value="select all"
/>
{% for x in lst %} {% set word = x[0]%}
<p>
<font color="grey">{{loop.index}}</font>
:
<a href='http://youdao.com/w/eng/{{word}}/#keyfrom=dict2.index' title={{word}}>{{word}}</a>
<a
href="http://youdao.com/w/eng/{{word}}/#keyfrom=dict2.index"
title="{{word}}"
>{{word}}</a
>
mrlan commented 2022-06-07 21:32:51 +08:00
Review

@yaaqob

Same thing here. Why break the line, <a href='http://youdao.com/w/eng/{{word}}/#keyfrom=dict2.index' title={{word}}>{{word}}</a> ?

Hui

@yaaqob Same thing here. Why break the line, `<a href='http://youdao.com/w/eng/{{word}}/#keyfrom=dict2.index' title={{word}}>{{word}}</a>` ? Hui
({{x[1]}})
<input type="checkbox" name="marked" value={{word}}>
<input
class="select-all"
type="checkbox"
name="marked"
value="{{word}}"
/>
</p>
{% endfor %}
</form>
{{ yml['footer'] | safe }}
{% if yml['js']['bottom'] %}
{% for js in yml['js']['bottom'] %}
{{ yml['footer'] | safe }} {% if yml['js']['bottom'] %} {% for js in
yml['js']['bottom'] %}
<script src="{{ js }}"></script>
{% endfor %}
{% endif %}
<script>
function checkall() {
mrlan commented 2022-06-07 21:35:32 +08:00
Review

@yaaqob

Please add a comment for function checkall.

Hui

@yaaqob Please add a comment for function `checkall`. Hui
const selectAllCheckBox = document.querySelectorAll(".select-all");
for (let i = 0; i < selectAllCheckBox.length; i++) {
selectAllCheckBox[i].checked = true;
}
}
</script>
{% endfor %} {% endif %}
</body>
</html>