mrlan
/
EnglishPal
4
0
Fork 11
Code Issues Pull Requests 22 Projects Releases Wiki Activity

i added select all function #26

Closed
yaaqob wants to merge 1 commits from bug209_yaaqobv2 into master
pull from: bug209_yaaqobv2
merge into: mrlan:master
Conversation 1 Commits 1 Files Changed 1
yaaqob commented 2022-06-06 17:14:18 +08:00

our bug was 209 and its content was to let the user to select all the words he want to save in one press rather than selecting one by one

our bug was 209 and its content was to let the user to select all the words he want to save in one press rather than selecting one by one
yaaqob self-assigned this 2022-06-06 17:14:18 +08:00
yaaqob added 1 commit 2022-06-06 17:14:18 +08:00
yaaqob requested review from mrlan 2022-06-06 17:14:32 +08:00
mrlan commented 2022-06-06 22:32:31 +08:00
Owner

Thanks. Someone will review your code. Please do not merge by yourself.

-Hui

Thanks. Someone will review your code. Please do not merge by yourself. -Hui
mrlan reviewed 2022-06-07 21:31:02 +08:00
app/templates/userpage_post.html
@ -6,0 +5,4 @@
<meta
name="viewport"
content="width=device-width, initial-scale=1.0, minimum-scale=0.5, maximum-scale=3.0, user-scalable=yes"
/>
mrlan commented 2022-06-07 21:31:02 +08:00
Owner

@yaaqob

Thanks. What is the point of breaking the following line into several lines?

<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=0.5, maximum-scale=3.0, user-scalable=yes" />

Hui

@yaaqob Thanks. What is the point of breaking the following line into several lines? `<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=0.5, maximum-scale=3.0, user-scalable=yes" />` Hui
mrlan reviewed 2022-06-07 21:32:51 +08:00
app/templates/userpage_post.html
@ -35,0 +36,4 @@
href="http://youdao.com/w/eng/{{word}}/#keyfrom=dict2.index"
title="{{word}}"
>{{word}}</a
>
mrlan commented 2022-06-07 21:32:51 +08:00
Owner

@yaaqob

Same thing here. Why break the line, <a href='http://youdao.com/w/eng/{{word}}/#keyfrom=dict2.index' title={{word}}>{{word}}</a> ?

Hui

@yaaqob Same thing here. Why break the line, `<a href='http://youdao.com/w/eng/{{word}}/#keyfrom=dict2.index' title={{word}}>{{word}}</a>` ? Hui
mrlan reviewed 2022-06-07 21:35:32 +08:00
app/templates/userpage_post.html
@ -47,0 +52,4 @@
{{ yml['footer'] | safe }} {% if yml['js']['bottom'] %} {% for js in
yml['js']['bottom'] %}
<script src="{{ js }}"></script>
<script>
mrlan commented 2022-06-07 21:35:32 +08:00
Owner

@yaaqob

Please add a comment for function checkall.

Hui

@yaaqob Please add a comment for function `checkall`. Hui
mrlan closed this pull request 2023-07-08 19:24:55 +08:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
mrlan
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
yaaqob
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/EnglishPal#26
There is no content yet.
Delete Branch "bug209_yaaqobv2"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?