mrlan
/
EnglishPal
4
0
Fork 11
Code Issues Pull Requests 22 Projects Releases Wiki Activity

DONE: Bug540-XiongJiaming #125

Merged
mrlan merged 5 commits from Bug540-XiongJiaming into Alpha-snapshot20240618 2024-08-29 07:53:49 +08:00
Conversation 7 Commits 5 Files Changed 3
xiongjiaming commented 2024-05-20 20:58:48 +08:00
There is no content yet.
xiongjiaming added 1 commit 2024-05-20 20:58:48 +08:00
xiongjiaming changed title from WIP: Bug540-XiongJiaming to WIP: Bug540-XiongJiaming 2024-05-20 21:02:08 +08:00
xiongjiaming changed title from WIP: Bug540-XiongJiaming to WIP: Bug540-XiongJiaming 2024-05-20 21:02:13 +08:00
xiongjiaming changed title from WIP: Bug540-XiongJiaming to Bug540-XiongJiaming 2024-05-20 21:03:13 +08:00
mrlan commented 2024-05-23 16:15:54 +08:00
Owner

@xiongjiaming

验证了一下，点击“标记文章”按钮，文章的题目会出现在右边的下拉列表中。

需要做以下改进

  • 下拉列表中第一条不能为空，应该是最新标记的文章

  • 点击下拉列表中的文章题目，跳转到那篇文章

Bug

退出后再登录，下拉列表中显示“selectedWords”，这个显然不是文章标题

@xiongjiaming 验证了一下，点击“标记文章”按钮，文章的题目会出现在右边的下拉列表中。 **需要做以下改进** - 下拉列表中第一条不能为空，应该是最新标记的文章 - 点击下拉列表中的文章题目，跳转到那篇文章 **Bug** 退出后再登录，下拉列表中显示“selectedWords”，这个显然不是文章标题
xiongjiaming added 1 commit 2024-05-26 20:41:29 +08:00
xiongjiaming commented 2024-05-26 20:47:14 +08:00
Poster

已改进

  1. 下拉列表中第一条不能为空，应该是最新标记的文章

  2. 点击下拉列表中的文章题目，跳转到那篇文章

需要将之前存储在localstorage中的内容清空，利用localstorage.clear()，只对最新标记的文章有效

Bug 退出后再登录，下拉列表中显示“selectedWords”，这个显然不是文章标题
已修复
@mrlan

已改进 1. 下拉列表中第一条不能为空，应该是最新标记的文章 2. 点击下拉列表中的文章题目，跳转到那篇文章 需要将之前存储在localstorage中的内容清空，利用localstorage.clear()，只对最新标记的文章有效 Bug 退出后再登录，下拉列表中显示“selectedWords”，这个显然不是文章标题 已修复 @mrlan
mrlan commented 2024-05-30 10:09:09 +08:00
Owner

@xiongjiaming

很不错，已经可以通过点击下列列表中的某个选项，实现文章跳转了。

还有个小问题：现在下拉列表中 selectedWords 还存在，请检查并修复。

@xiongjiaming 很不错，已经可以通过点击下列列表中的某个选项，实现文章跳转了。 还有个小问题：现在下拉列表中 selectedWords 还存在，请检查并修复。
mrlan reviewed 2024-05-30 10:10:55 +08:00
app/test/test_bug540_xiongjiaming.py Outdated
@ -0,0 +42,4 @@
# 输出异常信息
logging.error(e)
# 关闭浏览器
driver.quit()
mrlan commented 2024-05-30 10:10:55 +08:00
Owner

@xiongjiaming

请删除 driver.quit()

因为 finally 里头有这个语句，可以确保 driver.quit() 总会被执行

@xiongjiaming 请删除 `driver.quit()` 因为 finally 里头有这个语句，可以确保 driver.quit() 总会被执行
xiongjiaming commented 2024-06-03 14:22:05 +08:00
Poster

已删除

已删除
mrlan commented 2024-05-30 10:13:25 +08:00
Owner

@xiongjiaming

请与目标分支同步一下，然后运行以下命令，确保能够通过所有测试。

pytest --html=pytest_report.html test_bug540_xiongjiaming.py test_bug545_HuangHuiLing.py test_bug551_DingZeYu.py test_bug528_tangjiao.py test_add_word.py test_bug544_tangxinyuan.py test_bug553_LinShan.py

@xiongjiaming 请与目标分支同步一下，然后运行以下命令，确保能够通过所有测试。 `pytest --html=pytest_report.html test_bug540_xiongjiaming.py test_bug545_HuangHuiLing.py test_bug551_DingZeYu.py test_bug528_tangjiao.py test_add_word.py test_bug544_tangxinyuan.py test_bug553_LinShan.py`
mpianadiego approved these changes 2024-05-30 23:35:23 +08:00
mpianadiego left a comment

After reviewing your test script, I find it well-structured with effective error handling and modular functions, demonstrating professionalism. To further improve, consider implementing utility functions for wait conditions and ensuring proper browser closure using a finally block, which would enhance its robustness and maintainability.

After reviewing your test script, I find it well-structured with effective error handling and modular functions, demonstrating professionalism. To further improve, consider implementing utility functions for wait conditions and ensuring proper browser closure using a finally block, which would enhance its robustness and maintainability.
xiongjiaming closed this pull request 2024-06-02 22:20:17 +08:00
xiongjiaming reopened this pull request 2024-06-02 22:22:09 +08:00
xiongjiaming added 1 commit 2024-06-03 10:38:23 +08:00
xiongjiaming closed this pull request 2024-06-03 10:41:35 +08:00
xiongjiaming reopened this pull request 2024-06-03 10:44:09 +08:00
xiongjiaming force-pushed Bug540-XiongJiaming from 7b979fa079 to d83809dcc7 2024-06-03 13:50:17 +08:00 Compare
xiongjiaming added 1 commit 2024-06-03 14:03:45 +08:00
xiongjiaming commented 2024-06-03 14:22:59 +08:00
Poster

已经修复会出意外出现selectedWords的问题

已经修复会出意外出现selectedWords的问题
xiongjiaming commented 2024-06-03 14:56:34 +08:00
Poster

已经运行过测试，但有几个失败了，查找问题似乎与selenium的版本有关

已经运行过测试，但有几个失败了，查找问题似乎与selenium的版本有关
屏幕截图 2024-06-03 145336.png
91 KiB
屏幕截图 2024-06-03 145608.png
91 KiB
屏幕截图 2024-06-03 145336.png 屏幕截图 2024-06-03 145608.png
mrlan changed title from Bug540-XiongJiaming to Bug540-XiongJiaming 2024-06-23 16:38:16 +08:00
mrlan changed target branch from Alpha-snapshot20230621 to Alpha-snapshot20230621OK 2024-06-23 16:38:16 +08:00
mrlan changed title from Bug540-XiongJiaming to DONE: Bug540-XiongJiaming 2024-06-23 17:06:15 +08:00
mrlan changed title from DONE: Bug540-XiongJiaming to DONE: Bug540-XiongJiaming 2024-08-29 07:28:40 +08:00
mrlan changed target branch from Alpha-snapshot20230621OK to Alpha-snapshot20240618 2024-08-29 07:28:41 +08:00
mrlan added 2 commits 2024-08-29 07:53:30 +08:00
mrlan merged commit 44d9c39d4b into Alpha-snapshot20240618 2024-08-29 07:53:49 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
mpianadiego
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/EnglishPal#125
There is no content yet.
Delete Branch "Bug540-XiongJiaming"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?