spm-slides.tex: single-purpose pull request.

1 files changed, 16 insertions, 0 deletions

diff --git a/spm-slides.tex b/spm-slides.tex
index 53e052e..f47bdc4 100644
--- a/spm-slides.tex
+++ b/spm-slides.tex
@@ -515,7 +515,23 @@ is when it becomes officially part of the project.
 
 ``\href{https://ben.balter.com/2014/11/06/rules-of-communicating-at-github/}{There’s only one way to change something}'', Pull Request.
 
+A pull request should have a single purpose.
 
+If you have many purposes, then create many branches and make many pull requests.
+
+Why?
+
+Easier to refer to a small item, and easier to review a small item.
+
+Example of multiple purposes in a single pull request:
+
+\href{https://github.com/lanlab-org/LRR/pull/21/}{Allowing all group member to submit assignment and allowing Lecturer to edit assignments}
+
+\href{https://github.com/lanlab-org/GeneExpressionScatterPlot-Yu-Ye/pull/4}{Update README.md, change user guidance, fix csv exporting display probelm}
+
+You should wait other people to review your changes before you merge them to the master branch.
+
+Exceptions: the changes are trivial, the changes are unlikely to break the build, or no review for more than one week.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 \foilhead{Essential Git Commands}