mrlan
/
LRR
3
0
Fork 2
Code Issues Pull Requests 7 Projects Releases Wiki Activity

Update 1: test cases 00-04 #29

Merged
mrlan merged 4 commits from SeleniumIbrahimUpdate-Ibrahim into master 2021-12-03 11:09:37 +08:00
Conversation 7 Commits 4 Files Changed 9
Ibrahim commented 2021-11-27 23:18:12 +08:00

WIP: this PR is a series of commits to update SeleniumIbrahim test scripts.

You can review the commits individually, but please do not merge them yet.

For more information see Update selenium test scripts on KanBan.

Thanks.

WIP: this PR is a series of commits to update [SeleniumIbrahim](http://121.4.94.30:3000/mrlan/LRR/src/branch/master/test/SeleniumIbrahim/test_kit) test scripts. You can review the commits individually, but please do not merge them yet. For more information see [Update selenium test scripts](http://118.25.96.118/kanboard/?controller=TaskViewController&action=show&task_id=1575&project_id=170) on KanBan. Thanks.
👍 1
Ibrahim self-assigned this 2021-11-27 23:18:12 +08:00
mrlan was assigned by Ibrahim 2021-11-27 23:18:12 +08:00
Ibrahim added 1 commit 2021-11-27 23:18:13 +08:00
mrlan commented 2021-11-28 21:16:44 +08:00
Owner

@Ibrahim

Thanks. Too busy these days. I will review this pull request within 24 (working) hours.
If I don't, remind me.

Hui

@Ibrahim Thanks. Too busy these days. I will review this pull request within 24 (working) hours. If I don't, remind me. Hui
Ibrahim commented 2021-11-29 00:46:35 +08:00
Poster

@Ibrahim

Thanks. Too busy these days. I will review this pull request within 24 (working) hours.
If I don't, remind me.

Hui

Great, take your time.

> @Ibrahim > > Thanks. Too busy these days. I will review this pull request within 24 (working) hours. > If I don't, remind me. > > Hui > > Great, take your time.
Ibrahim added 1 commit 2021-11-29 02:20:37 +08:00
mrlan reviewed 2021-11-30 21:37:53 +08:00
test/SeleniumIbrahim/test_kit/admin.py Outdated
@ -33,3 +33,3 @@
#Locate "Admin" tab.
wait = WebDriverWait(driver, 10)
admin = wait.until(EC.presence_of_element_located((By.XPATH, "/html/body/nav/div/form/a[1]")))
admin = wait.until(EC.presence_of_element_located((By.ID, "admin_btn")))
mrlan commented 2021-11-30 21:37:53 +08:00
Owner

@Ibrahim

Great. Usig By.ID is much more readable and robust.

Hui

@Ibrahim Great. Usig By.ID is much more readable and robust. Hui
mrlan reviewed 2021-11-30 21:41:22 +08:00
mrlan added 1 commit 2021-11-30 21:50:19 +08:00
mrlan commented 2021-11-30 22:03:07 +08:00
Owner

Thanks. Could you do the following replacement? It is quite tedious. If you don't want to do that, I will do that. The purpose is to make the ID names more clear.

  • Replace signup_btn with signup_link
  • Replace sign_btn with signup_btn
  • Replace acc with account
  • Replace frm with form
  • Replace rad with role
  • Replace reg with register
  • Replace inst with instructor
  • Replace ind with individual
  • Replace grp with group
  • Replace cname with course_name
  • Replace ccode with course_code
  • Replace ayear with academic_year
  • Replace fac with faculty
  • Repalce jno with join_no
  • Replace jyes with join_yes
  • Replace std_id with student_id

Nowadays, readability is more important than saving storage for a dozon of characters. Storage is cheap. Time is expensive.

Hui

Thanks. Could you do the following replacement? It is quite tedious. If you don't want to do that, I will do that. The purpose is to make the ID names more clear. - Replace signup_btn with signup_link - Replace sign_btn with signup_btn - Replace acc with account - Replace frm with form - Replace rad with role - Replace reg with register - Replace inst with instructor - Replace ind with individual - Replace grp with group - Replace cname with course_name - Replace ccode with course_code - Replace ayear with academic_year - Replace fac with faculty - Repalce jno with join_no - Replace jyes with join_yes - Replace std_id with student_id Nowadays, readability is more important than saving storage for a dozon of characters. Storage is cheap. Time is expensive. Hui
Ibrahim commented 2021-12-02 16:20:14 +08:00
Poster

Thanks. Could you do the following replacement? It is quite tedious. If you don't want to do that, I will do that. The purpose is to make the ID names more clear.

  • Replace signup_btn with signup_link
  • Replace sign_btn with signup_btn
  • Replace acc with account
  • Replace frm with form
  • Replace rad with role
  • Replace reg with register
  • Replace inst with instructor
  • Replace ind with individual
  • Replace grp with group
  • Replace cname with course_name
  • Replace ccode with course_code
  • Replace ayear with academic_year
  • Replace fac with faculty
  • Repalce jno with join_no
  • Replace jyes with join_yes
  • Replace std_id with student_id

Nowadays, readability is more important than saving storage for a dozon of characters. Storage is cheap. Time is expensive.

Hui

Will do. All updates plus ID names replacements should be done before next class.

Thanks.

> Thanks. Could you do the following replacement? It is quite tedious. If you don't want to do that, I will do that. The purpose is to make the ID names more clear. > > > - Replace signup_btn with signup_link > - Replace sign_btn with signup_btn > - Replace acc with account > - Replace frm with form > - Replace rad with role > - Replace reg with register > - Replace inst with instructor > - Replace ind with individual > - Replace grp with group > - Replace cname with course_name > - Replace ccode with course_code > - Replace ayear with academic_year > - Replace fac with faculty > - Repalce jno with join_no > - Replace jyes with join_yes > - Replace std_id with student_id > > Nowadays, readability is more important than saving storage for a dozon of characters. Storage is cheap. Time is expensive. > > Hui Will do. All updates plus ID names replacements should be done before next class. Thanks.
👍 1
Ibrahim added 1 commit 2021-12-03 10:58:35 +08:00
mrlan commented 2021-12-03 11:08:43 +08:00
Owner

Thanks, Ibrahim. Great work.

Hui

Thanks, Ibrahim. Great work. Hui
mrlan merged commit f4ffcdd47b into master 2021-12-03 11:09:37 +08:00
Ibrahim commented 2021-12-03 11:16:22 +08:00
Poster

Thanks, Ibrahim. Great work.

Hui

Thank you for the merge. However, I didn't wish to merge this PR until all test scripts are updated.

WIP: this PR is a series of commits to update SeleniumIbrahim test scripts.

You can review the commits individually, but please do not merge them yet.

For more information see Update selenium test scripts on KanBan.

Thanks.

> Thanks, Ibrahim. Great work. > > Hui Thank you for the merge. However, I didn't wish to merge this PR until all test scripts are updated. > WIP: this PR is a series of commits to update SeleniumIbrahim test scripts. > You can review the commits individually, but please do not merge them yet. > For more information see Update selenium test scripts on KanBan. > Thanks.
mrlan commented 2021-12-03 13:00:37 +08:00
Owner

Thanks, Ibrahim. Great work.

Hui

Thank you for the merge. However, I didn't wish to merge this PR until all test scripts are updated.

WIP: this PR is a series of commits to update SeleniumIbrahim test scripts.

You can review the commits individually, but please do not merge them yet.

For more information see Update selenium test scripts on KanBan.

Thanks.

@Ibrahim

Sorry, my fault. Please create a new pull request from the same branch SeleniumIbrahimUpdate-Ibrahim.

Hui

> > Thanks, Ibrahim. Great work. > > > > Hui > > Thank you for the merge. However, I didn't wish to merge this PR until all test scripts are updated. > > WIP: this PR is a series of commits to update SeleniumIbrahim test scripts. > > > You can review the commits individually, but please do not merge them yet. > > > For more information see Update selenium test scripts on KanBan. > > > Thanks. > @Ibrahim Sorry, my fault. Please create a new pull request from the same branch `SeleniumIbrahimUpdate-Ibrahim`. Hui
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Ibrahim
mrlan
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mrlan/LRR#29
There is no content yet.
Delete Branch "SeleniumIbrahimUpdate-Ibrahim"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?