Demo video shows that the modification works
Co-authored-by: Hui Lan <lanhui@zjnu.edu.cn>
Reviewed-on: http://121.4.94.30:3000/mrlan/LRR/pulls/53
Co-authored-by: mrlan <mrlan@noreply.121.4.94.30>
Co-committed-by: mrlan <mrlan@noreply.121.4.94.30>
When a student enters a student number without the email he/she can not recover their password unless the enter both details and if not all details are correct the following error messages will be displayed; "Invalid student number" or "Invalid email address". These error messages will be displayed on the same page without navigating to the next page as before.
Line 222 - 224 and 230 - 232.
On Line 246 - 247 after resetting your password the recover buttons navigates direct to the signup.php where you can create a new account.
Student can create the accounts on their own without the need for the Teacher to create the accounts for the students.
Also removed the inputs for the passport.
Line 44, 53 - 60 we removed the passport portal not just from the form as our colleagues did but completely. Apart from the change above we also added a portal for inputting the student number on line 64.
Fixed some tying errors as well as grammatical errors.
Tanaka Michelle Sandati (201732120134)
Yeboah Martha Asamoah (201732120135)
Tamene Robel (201732120170)
This commit temporarily fixed the bug reported at http://118.25.96.118/bugzilla/show_bug.cgi?id=65
This bug was introduced after a recent functionality addition, i.e., allowing Lecturer to edit assignment information.
See the following pull request for details.
https://github.com/lanlab-org/LRR/pull/21
It seems that $group_id is not properly assigned after merging the above pull request.
Therefore, when someone tried to insert a record to the database table lab_report_submissions, he encountered a running error.
In this fix, I just set $group_id 0 to avoid the database insertion error.
This is OK when an assignment is of type Individual.
Of course, this fix is not ideal, as it cannot handle the situation where the assignment is of type Group.
In the future, $group_id must be properly initialized, depending on the assignment type.
-Hui
Following the previous update, the system failed a regression test and reported a 4441 error while trying to submit a new Lab report.
This was due to the condition added on line 298 in Course.php and reversing this change solved the problem.
This condition was added to allow all Group members to be updated once the Tutor Marks the Lab Report but a better method to
archieve this has been implemented on line 367 in Course.php
Two Issues have been Fixed
1)Firstly
Only Group Admins were able to submit group assignments and the system was indicating to other members that they missed the deadline.
This Problems was solved through the following stages:
Create 4 new columns 'Member_ID1-4 Varchar(50) DEFAULT 0' in the database table 'course_group_table' (this will limit each group to max 5 members you can check the file Script.php from line 1071.)
Changing the SQL query in SubmitLab.php to allow both Group Member and Group Admin to submit assignment. (However for this feature to take effect with backward compat, the group admin might need to invite other members again into the group or else they still wont be able to submit but all the group assignments will indicate that they have been submitted by the admin. For any new group after the update it works perfect.)
Changing the Course.php allows other members to be updated once 1 member submit the assignment.
2)Secondly
The Tutor couldnt modify assignments once posted.
Adding an 'Edit' Button on the Tutor's page allows him to modify new and old assignment without any duplications. This feature afftected Courses.php from line 109.
Group
Ashly Tafadzwa Dhani 201632120150
Samantha Rusike 201632120140
Edited by Ashly
Removed the insertion of encripted password into the 'HashPassword' column. All passwords are kept in the 'Password' Column.
Also adjusted the Column size of database to hold the long hashed password
Make sure the really old, legitimate users could still login.
Note that these users' passwords were first encrypted by SHA512 then stored in column HashPassword.
In recent updates, we totally disuse HashPassword. The hashed password (using Php's built-in function password_hash) is stored in column Password instead.
- Group: Ashly Tafadzwa Dhani, Samantha Rusike
2020-03-18
this change is on line 160. it allows both new users and old users to loginto the system successfully by verifying hashed passwords and normal passwords
mrlan
Hui Lan
Adjei Kingsley
YAKUBU ABDULAI
徐宣
bmth
Goldenbwuoy
AL BOROM WARD
enockkays
Samantha
xiaoyusoil
fish
Software Project Management
TanakaMichelle
CloudStarTreck