From f2aa60c994e2de482902c66aaa2eefb95a1121f8 Mon Sep 17 00:00:00 2001 From: Lan Hui Date: Fri, 3 May 2024 15:34:39 +0800 Subject: [PATCH] Define extra fixtures (i.e., driver, url, admin_username, admin_password) in conftest.py and use them --- test/SeleniumMpiana/conftest.py | 22 ++++-- test/SeleniumMpiana/test_bug418_yaaqob.py | 83 +++++++++++------------ 2 files changed, 57 insertions(+), 48 deletions(-) diff --git a/test/SeleniumMpiana/conftest.py b/test/SeleniumMpiana/conftest.py index bf0d051..704cdb7 100644 --- a/test/SeleniumMpiana/conftest.py +++ b/test/SeleniumMpiana/conftest.py @@ -1,5 +1,6 @@ import os import pytest +from selenium import webdriver @pytest.fixture @@ -18,9 +19,7 @@ def restore_database(): f'mysql -u root -p{PASSWORD} -e "DROP DATABASE IF EXISTS {DB_NAME};"', f'mysql -u root -p{PASSWORD} -e "CREATE DATABASE {DB_NAME};"', f'mysql -u root -p{PASSWORD} -e "GRANT ALL PRIVILEGES ON {DB_NAME}.* TO lrr@localhost WITH GRANT OPTION;"', - f'mysql -u root -p{PASSWORD} {DB_NAME} < lrr_database.sql'] - - yield + f'mysql -u root -p{PASSWORD} {DB_NAME} < ../../lrr_database.sql'] for command in cmds: os.system(command) @@ -29,4 +28,19 @@ def restore_database(): @pytest.fixture def url(): - return '' # URL of the LRR \ No newline at end of file + return 'http://localhost/LRR/' # URL of LRR + + +@pytest.fixture +def driver(): + return webdriver.Chrome() + + +@pytest.fixture +def admin_username(): + return 'admin@qq.com' + + +@pytest.fixture +def admin_password(): + return '123' diff --git a/test/SeleniumMpiana/test_bug418_yaaqob.py b/test/SeleniumMpiana/test_bug418_yaaqob.py index 155d353..2c2835d 100644 --- a/test/SeleniumMpiana/test_bug418_yaaqob.py +++ b/test/SeleniumMpiana/test_bug418_yaaqob.py @@ -6,15 +6,11 @@ from selenium.webdriver.support.ui import WebDriverWait from selenium.webdriver.support import expected_conditions as EC from selenium.common.exceptions import NoSuchElementException, UnexpectedAlertPresentException -# Credentials for login, make sure to create a user with Admin role for these test to work -username = "" # Admin user email -password = "" # Admin user password -driver = webdriver.Chrome() -driver.get("") # URL of the LRR - -def login(driver, username, password): +def login(driver, url, username, password): try: + driver.get(url) + # Fill in the login form user_input = WebDriverWait(driver, 10).until( EC.element_to_be_clickable((By.ID, "user_name")) @@ -36,24 +32,22 @@ def login(driver, username, password): admin_tab = WebDriverWait(driver, 10).until( EC.element_to_be_clickable((By.ID, "admin_tab")) ) - - return True - except (NoSuchElementException, UnexpectedAlertPresentException) as e: return f"Error: {str(e)}" @pytest.mark.parametrize("course_id, course_name, ta_name", [(1, "Teecloudy - Ashly Course Testing", "Mark")]) -def test_assign_a_new_ta_to_a_course(course_id, course_name, ta_name): +def test_assign_a_new_ta_to_a_course(course_id, course_name, ta_name, driver, url, admin_username, admin_password, restore_database): try: + driver.maximize_window() - login(driver, username, password) + login(driver, url, admin_username, admin_password) admin_tab = WebDriverWait(driver, 10).until( EC.element_to_be_clickable((By.ID, "admin_tab")) ) admin_tab.click() - + # Locate the form and select the TA ta_form = WebDriverWait(driver, 15).until( EC.presence_of_element_located((By.XPATH, f"//form[@id='drop_menu_form_{course_id}']")) @@ -77,10 +71,6 @@ def test_assign_a_new_ta_to_a_course(course_id, course_name, ta_name): # assert the TA name in the column assert ta_name in ta_column.text, f"Error: TA name {ta_name} not found in the column {ta_column.text}" - driver.quit() - - return True - except NoSuchElementException as e: return f"Error: {str(e)}" except UnexpectedAlertPresentException as e: @@ -89,45 +79,55 @@ def test_assign_a_new_ta_to_a_course(course_id, course_name, ta_name): return f"Error: {str(e)}" except Exception as e: return f"Error: {str(e)}" + finally: + driver.quit() @pytest.mark.parametrize("course_id, course_name, ta_name", [(1, "Teecloudy - Ashly Course Testing", "Mark")]) -def test_assign_the_same_ta_to_the_same_course_twice(course_id, course_name, ta_name, restore_database): +def test_assign_the_same_ta_to_the_same_course_twice(course_id, course_name, ta_name, driver, url, admin_username, admin_password, restore_database): try: - - login(driver, username, password) + driver.maximize_window() + login(driver, url, admin_username, admin_password) admin_tab = WebDriverWait(driver, 10).until( EC.element_to_be_clickable((By.ID, "admin_tab")) ) admin_tab.click() - # find table courses - table_courses_before = WebDriverWait(driver, 10).until( - EC.presence_of_element_located((By.XPATH, ".//*[@id='tab-existing-courses']/table")) - ) - # find the row with matching course_name - course_row_before = table_courses_before.find_element(By.XPATH, f".//tr[td='{course_name}']") - # find the column with TA name - old_cell_content = course_row_before.find_element(By.XPATH, ".//td[4]") - - # Locate the form and select the TA + # Hui: assign the TA for the first time + # (1) Locate the form and select the TA ta_form = WebDriverWait(driver, 15).until( - EC.presence_of_element_located((By.XPATH, f"//form[@id='drop_menu_form_{course_id}']")) - ) + EC.presence_of_element_located((By.XPATH, + f"//form[@id='drop_menu_form_{course_id}']")) ) ta_dropdown = Select(ta_form.find_element(By.XPATH, ".//select[@name='ta']")) ta_dropdown.select_by_visible_text(ta_name) - # Submit the form using JavaScript + # (2) Submit the form using JavaScript driver.execute_script("arguments[0].submit();", ta_form) + # (3) Find table courses + table_courses_before = WebDriverWait(driver, 10).until( + EC.presence_of_element_located((By.XPATH, ".//*[@id='tab-existing-courses']/table")) + ) + # (4) Find the row with matching course_name + course_row_before = table_courses_before.find_element(By.XPATH, f".//tr[td='{course_name}']") + # (5) Find the column with TA name + old_cell_content = course_row_before.find_element(By.XPATH, ".//td[4]").text + + + # Hui: assign the same TA again + ta_form = WebDriverWait(driver, 15).until(EC.presence_of_element_located((By.XPATH, f"//form[@id='drop_menu_form_{course_id}']"))) + ta_dropdown = Select(ta_form.find_element(By.XPATH, ".//select[@name='ta']")) + ta_dropdown.select_by_visible_text(ta_name) + driver.execute_script("arguments[0].submit();", ta_form) + # Wait for an expected alert and accept it WebDriverWait(driver, 10).until(EC.alert_is_present()) alert = driver.switch_to.alert alert_text = alert.text alert.accept() - + # find table courses table_courses_after = WebDriverWait(driver, 10).until( EC.presence_of_element_located((By.XPATH, ".//*[@id='tab-existing-courses']/table")) @@ -135,23 +135,18 @@ def test_assign_the_same_ta_to_the_same_course_twice(course_id, course_name, ta_ # find the row with matching course_name course_row_after = table_courses_after.find_element(By.XPATH, f".//tr[td='{course_name}']") # find the column with TA name - new_cell_content = course_row_after.find_element(By.XPATH, ".//td[4]") + new_cell_content = course_row_after.find_element(By.XPATH, ".//td[4]").text # assert the TA name in the column assert old_cell_content == new_cell_content, f"Error: TA name in the column has changed from {old_cell_content} to {new_cell_content}" - assert alert_text == "The selected TA is already assigned to this course.", f"Error: Alert text is not as expected: {alert_text}" - assert restore_database == None, f"Error: Database was not restored" - - driver.quit() - - return True, alert_text except NoSuchElementException as e: return f"Error: {str(e)}" except UnexpectedAlertPresentException as e: return f"Error: {str(e)}" except AssertionError as e: - return f"Error: {str(e)}" + return f"Error: {str(e)}" except Exception as e: - return f"Error: {str(e)}" - \ No newline at end of file + return f"Error: {str(e)}" + finally: + driver.quit()