From a8b235052f5f4171614dbb3c7c05b42444e42e34 Mon Sep 17 00:00:00 2001
From: Lan Hui <lanhui@zjnu.edu.cn>
Date: Fri, 8 Sep 2023 19:46:51 +0800
Subject: [PATCH] Courses.php: better spacing and better variable name (fname
 -> faculty)

---
 Courses.php | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/Courses.php b/Courses.php
index cc4b104..3f544d7 100644
--- a/Courses.php
+++ b/Courses.php
@@ -610,14 +610,13 @@ include 'Header.php';
                         <div class='col-md-5'>
                             List courses by faculty
                             <select name='faculty' class='form-control'>";
-		$result = mysqli_query($con,"SELECT   DISTINCT(Faculty) as Faculty FROM `courses_table`");
-		if(mysqli_num_rows($result)==0){
-		} else {
-		    echo"           <option value=''>Search by faculty</option>";
+		$result = mysqli_query($con, "SELECT DISTINCT(Faculty) AS Faculty FROM courses_table");
+		if (mysqli_num_rows($result) > 0){
 		    while($row = mysqli_fetch_assoc($result)) {
-			$fname=$row['Faculty'];
-			echo "      <option value='$fname'> $fname </option>";
-		}}
+                $faculty = $row['Faculty'];
+                echo "      <option value='$faculty'> $faculty </option>";
+            }
+        }
 
 		echo "          </select>
                         </div>
@@ -629,10 +628,9 @@ include 'Header.php';
                 </div>
             </div>
         </form>
-
     </div></div>";
 
-		}
+    }
 
 		?>