mrlan
/
LRR
3
0
Fork 2
Code Issues Pull Requests 7 Projects Releases Wiki Activity

Merge pull request 'Fix the id number verification bug' (#31) from IDVerificationBug-Golden into master 

Reviewed-on: http://121.4.94.30:3000/mrlan/LRR/pulls/31
AutoTesting-Golden
mrlan 2021-12-14 12:46:18 +08:00
parent 3f81266852 dd75c24a30
commit 8b91a8ed7f
2 changed files with 20 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
Script.php
View File

@ -34,39 +34,37 @@ function is_valid_student_number($student_id)
} }
// ############################### SIGN UP ################################## // ############################### SIGN UP ##################################
if (!empty($_POST["frm_signup_1"])) { if (!empty($_POST["form_signup"])) {
$student_id = trim(mysqli_real_escape_string($con, $_POST["student_id"])); $student_id = trim(mysqli_real_escape_string($con, $_POST["user_student_id"]));
// validate student number // validate student number
if (!is_valid_student_number($student_id)) { if (!is_valid_student_number($student_id)) {
$_SESSION["info_signup1"] = "Invalid student number."; $_SESSION["info_signup"] = "Invalid student number.";
header("Location: index.php"); header("Location: signup.php");
return; return;
} }
// Check if this student number is a legal one // Check if this student number is a legal one
$result = mysqli_query($con, "SELECT * FROM `students_data` WHERE Student_ID='$student_id'"); $result = mysqli_query($con, "SELECT * FROM `students_data` WHERE Student_ID='$student_id'");
if (mysqli_num_rows($result) == 0) { if (mysqli_num_rows($result) == 0) {
$_SESSION["info_signup1"] = "Your entered student number could not be verified. Please contact Student Management Office <lanhui at zjnu.edu.cn>. Thanks."; $_SESSION["info_signup"] = "Your entered student number could not be verified. Please contact Student Management Office <lanhui at zjnu.edu.cn>. Thanks.";
header("Location: index.php"); header("Location: signup.php");
return; return;
} }
$result98 = mysqli_query($con, "SELECT * FROM `users_table` WHERE Student_ID='$student_id'"); // Check if the student number isn't already registered
if (mysqli_num_rows($result98) == 0) {
$_SESSION['user_student_id'] = $student_id; $student_result = mysqli_query($con, "SELECT * FROM `users_table` WHERE Student_ID='$student_id'");
if (mysqli_num_rows($student_result) > 0) {
$_SESSION["info_signup"] = "This Student ID is already in use! Please contact Student Management Office <lanhui at zjnu.edu.cn> for help.";
header("Location: signup.php"); header("Location: signup.php");
return; return;
} else {
$_SESSION["info_signup1"] = "This Student ID is already in use! Please contact Student Management Office <lanhui at zjnu.edu.cn> for help.";
header("Location: index.php");
return;
} }
} }
// ############################### CREATE STUDENT USER ################################## // ############################### CREATE STUDENT USER ##################################
if (!empty($_POST["frm_signup_2"])) { if (!empty($_POST["form_signup"])) {
$fullname = mysqli_real_escape_string($con, $_POST["fullname"]); $fullname = mysqli_real_escape_string($con, $_POST["fullname"]);
$student_id = mysqli_real_escape_string($con, $_POST["user_student_id"]); $student_id = mysqli_real_escape_string($con, $_POST["user_student_id"]);
$email = mysqli_real_escape_string($con, $_POST["email"]); $email = mysqli_real_escape_string($con, $_POST["email"]);
@ -79,7 +77,7 @@ if (!empty($_POST["frm_signup_2"])) {
// check confirmed password // check confirmed password
if (strcasecmp($password, $confirmpassword) != 0) { if (strcasecmp($password, $confirmpassword) != 0) {
$_SESSION['info_signup2'] = "Password confirmation failed."; $_SESSION['info_signup'] = "Password confirmation failed.";
$_SESSION['user_fullname'] = null; // such that Header.php do not show the header information. $_SESSION['user_fullname'] = null; // such that Header.php do not show the header information.
header("Location: signup.php"); header("Location: signup.php");
return; return;
@ -87,7 +85,7 @@ if (!empty($_POST["frm_signup_2"])) {
// validate email // validate email
if (!filter_var($email, FILTER_VALIDATE_EMAIL)) { if (!filter_var($email, FILTER_VALIDATE_EMAIL)) {
$_SESSION['info_signup2'] = "Invalid email address."; $_SESSION['info_signup'] = "Invalid email address.";
header("Location: signup.php"); header("Location: signup.php");
return; return;
} }
@ -100,7 +98,7 @@ if (!empty($_POST["frm_signup_2"])) {
// check for strong password // check for strong password
if (!$containsAll) { if (!$containsAll) {
$_SESSION['info_signup2'] = "Password must have at least characters that include lowercase letters, uppercase letters, numbers and sepcial characters (e.g., !?.,*^)."; $_SESSION['info_signup'] = "Password must have at least characters that include lowercase letters, uppercase letters, numbers and sepcial characters (e.g., !?.,*^).";
header("Location: signup.php"); header("Location: signup.php");
return; return;
} }
@ -109,7 +107,7 @@ if (!empty($_POST["frm_signup_2"])) {
$result = mysqli_query($con, "SELECT * FROM users_table WHERE email='$email'"); $result = mysqli_query($con, "SELECT * FROM users_table WHERE email='$email'");
if(mysqli_num_rows($result) != 0) if(mysqli_num_rows($result) != 0)
{ {
$_SESSION["info_signup2"]="Email address ".$email." is already in use."; $_SESSION["info_signup"]="Email address ".$email." is already in use.";
$_SESSION['user_fullname'] = null; $_SESSION['user_fullname'] = null;
header("Location: signup.php"); header("Location: signup.php");
return; return;

8
signup.php
View File

@ -18,7 +18,7 @@ include 'Header.php';
<div class="panel-body"> <div class="panel-body">
<form method="post" action="Script.php" id="signup_form"> <form method="post" action="Script.php" id="signup_form">
<input type="hidden" name="frm_signup_2" value="true" /> <input type="hidden" name="form_signup" value="true" />
Full Name Full Name
<input type="text" name="fullname" placeholder="Your full name" class="form-control" value="<?php echo $_SESSION['user_fullname']; ?>" required="required" id="full_name"/> <input type="text" name="fullname" placeholder="Your full name" class="form-control" value="<?php echo $_SESSION['user_fullname']; ?>" required="required" id="full_name"/>
@ -37,9 +37,9 @@ include 'Header.php';
<input type="submit" class="btn-primary" value="Sign up" id="signup_btn"> <input type="submit" class="btn-primary" value="Sign up" id="signup_btn">
<?php <?php
error_reporting(E_ALL); error_reporting(E_ALL);
if (isset($_SESSION['info_signup2'])) { if (isset($_SESSION['info_signup'])) {
echo '<hr><div class="alert alert-danger" role="alert">' . $_SESSION['info_signup2'] . '</div>'; echo '<hr><div class="alert alert-danger" role="alert">' . $_SESSION['info_signup'] . '</div>';
$_SESSION['info_signup2'] = null; $_SESSION['info_signup'] = null;
} }
?> ?>
</form> </form>