mrlan
/
LRR
3
0
Fork 2
Code Issues Pull Requests 7 Projects Releases Wiki Activity

Courses.php: improve search logic

Bug430-Eden2
Lan Hui 2023-09-07 19:49:35 +08:00
parent 79a928354b
commit 1cac6bebea
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Courses.php
View File

@ -506,27 +506,26 @@ include 'Header.php';
<?php <?php
error_reporting(0); error_reporting(0);
$student_id= $_SESSION['user_student_id']; $student_id = $_SESSION['user_student_id'];
// current academic year - i.e 2021 - 2022 , so we will show in search result: // current academic year - i.e 2021 - 2022 , so we will show in search result:
// course containing either 2021 or 2022 as academic year. // course containing either 2021 or 2022 as academic year.
$oldest_academic_year = date('Y') - 1; $oldest_academic_year = date('Y') - 1;
if(!empty($_GET["search"]) || !empty($_GET["faculty"])) if (!empty($_GET["search"]) || !empty($_GET["faculty"])) {
{
$search = trim(mysqli_real_escape_string($con, $_GET["search"])); $search = trim(mysqli_real_escape_string($con, $_GET["search"]));
$search = strtoupper($_GET['search']); $search = strtoupper($search); # was strtoupper($_GET['search']);
$faculty = mysqli_real_escape_string($con, $_GET["faculty"]); $faculty = mysqli_real_escape_string($con, $_GET["faculty"]);
// the user has not entered something under "Find course by Code" // the user has not entered something under "Find course by Code"
if($faculty=="") if($search != "" && $faculty == "")
{ {
echo "<h4> Search results for course code: $search </h4><hr>"; echo "<h4>Search results for course code: $search </h4><hr>";
$result = mysqli_query($con,"SELECT `Course_ID`, `Course_Name`, `Academic_Year`, `Faculty`," $result = mysqli_query($con,"SELECT `Course_ID`, `Course_Name`, `Academic_Year`, `Faculty`,"
. " `Lecturer_User_ID`, `TA_User_ID`, `Course_Code`, `URL`, `Verify_New_Members` " . " `Lecturer_User_ID`, `TA_User_ID`, `Course_Code`, `URL`, `Verify_New_Members` "
. " , users_table.Full_Name FROM `courses_table` INNER JOIN users_table" . " , users_table.Full_Name FROM `courses_table` INNER JOIN users_table"
. " ON users_table.User_ID=courses_table.Lecturer_User_ID where Academic_Year >= $oldest_academic_year and Course_Code like '%{$search}%' and courses_table.Course_ID not in (select course_id from course_students_table where Student_ID=$student_id) order by Academic_Year desc"); . " ON users_table.User_ID=courses_table.Lecturer_User_ID where Academic_Year >= $oldest_academic_year and Course_Code like '%{$search}%' and courses_table.Course_ID not in (select course_id from course_students_table where Student_ID=$student_id) order by Academic_Year desc");
} }
// the user has entered something under "Find course by Code" // the user has entered something under "Find course by Code"
else else if ($faculty != "")
{ {
echo "<h3> Find courses under faculty: $faculty</h3>"; echo "<h3> Find courses under faculty: $faculty</h3>";
$result = mysqli_query($con,"SELECT `Course_ID`, `Course_Name`, `Academic_Year`, `Faculty`, $result = mysqli_query($con,"SELECT `Course_ID`, `Course_Name`, `Academic_Year`, `Faculty`,