kasoka
/
LRR
forked from mrlan/LRR
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #33 from lanlab-org/Hui-bugfix-65 

Hui bugfix 65 "Students unable to submit assignment after a recent change"
SIMPLICITY_Bug-189_Course_Delete_btn
Software Project Management 2020-04-23 10:22:25 +08:00 committed by GitHub
parent 058eb2adac a89b8f4e0d
commit ec80d4c6b0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Courses.php
View File

@ -139,7 +139,7 @@ New Date/Time <br><input type="date" name="date" required=""> <input type="time"
$sql = "UPDATE `lab_reports_table` SET `Deadline` = ('" . $Deadline . "'), `Instructions` = ('" . $instructions . "'), `Title` = ('" . $title . "'), `Marks` = ('" . $marks . "') WHERE `lab_reports_table`.`Lab_Report_ID` = '$getid'"; $sql = "UPDATE `lab_reports_table` SET `Deadline` = ('" . $Deadline . "'), `Instructions` = ('" . $instructions . "'), `Title` = ('" . $title . "'), `Marks` = ('" . $marks . "') WHERE `lab_reports_table`.`Lab_Report_ID` = '$getid'";
if ($con->query($sql) === TRUE) { if ($con->query($sql) === TRUE) {
$_SESSION["info_Updated"]="Information Updated Successfull"; $_SESSION["info_updated"]="Assignment information updated successfully.";
} else { } else {
echo "Error: " . $sql . "<br>" . $con->error; echo "Error: " . $sql . "<br>" . $con->error;
@ -253,9 +253,9 @@ Submission Type <input type='radio' name='type' value='Individual' required=''>
echo "<div class='col-md-7'> <h3> Lab Report Assignment list </h3>"; echo "<div class='col-md-7'> <h3> Lab Report Assignment list </h3>";
error_reporting(0); error_reporting(0);
if(isset($_SESSION["info_Updated"])){ if(isset($_SESSION["info_updated"])){
echo '<hr><div class="alert alert-info" role="alert">' . $_SESSION['info_Updated'] . '</div>'; echo '<hr><div class="alert alert-info" role="alert">' . $_SESSION['info_updated'] . '</div>';
$_SESSION['info_Updated'] = null; $_SESSION['info_updated'] = null;
} }
if (isset($_SESSION['info_courses'])) { if (isset($_SESSION['info_courses'])) {
echo '<hr><div class="alert alert-info" role="alert">' . $_SESSION['info_courses'] . '</div>'; echo '<hr><div class="alert alert-info" role="alert">' . $_SESSION['info_courses'] . '</div>';

8
Script.php
View File

@ -827,7 +827,13 @@ if(strlen($_FILES['attachment1']['name']) > 2 ) {
if ($con->query($sql1) === TRUE) { if ($con->query($sql1) === TRUE) {
} }
// When $group_id is not properly initialized, use integer 0 as its value.
// This temporarily fixed the "Students unable to submit assignment after a recent change" bug at http://118.25.96.118/bugzilla/show_bug.cgi?id=65
if (trim($group_id) === '') { // when $group_id is an empty string or contains only whitespace characters.
$group_id = 0; // FIXME
}
$sql="INSERT INTO `lab_report_submissions`(`Submission_Date`, `Lab_Report_ID`, `Student_id`," $sql="INSERT INTO `lab_report_submissions`(`Submission_Date`, `Lab_Report_ID`, `Student_id`,"
. " `Course_Group_id`, `Attachment1`, `Notes`, `Attachment2`, `Attachment3`, `Attachment4`, `Status`, `Title`,`Remarking_Reason`)" . " `Course_Group_id`, `Attachment1`, `Notes`, `Attachment2`, `Attachment3`, `Attachment4`, `Status`, `Title`,`Remarking_Reason`)"
. " VALUES ('$date',$lab_id,$student_id,$group_id,'$targetfile','$instructions','$targetfile2','$targetfile3','$targetfile4'," . " VALUES ('$date',$lab_id,$student_id,$group_id,'$targetfile','$instructions','$targetfile2','$targetfile3','$targetfile4',"