Bug 231

Summary: Duplicate functionality for creating a new course
Product: Lab Report Repository (nor houzi) Reporter: Hui Lan <lanhui>
Component: Design errorAssignee: IBRAHIM MOHAMED IBRAHIM ISMAIL <1525200991>
Status: RESOLVED FIXED    
Severity: critical CC: 1525200991, mohamednor
Priority: ---    
Version: unspecified   
Hardware: PC   
OS: Windows   

Description Hui Lan 2021-04-08 15:25:54 CST 
Overview
---------

Duplicate functionality for creating a new course.
An instructor could create a course under Admin (http://118.25.96.118/nor/Admin.php) or under Courses (http://121.4.94.30/lrr-testbed/Courses.php).

Suggestion: keep the second option (i.e., creating a new course under Courses).


Steps to Reproduce
-------------------

Via Admin:

1. Log in as an instructor at http://121.4.94.30/lrr-testbed 
   
   Username: 202032070221
   Password: aA124536!


2. Go to Admin (http://121.4.94.30/lrr-testbed/Admin.php)
   
   Fill in the following information.

     Course name: Fake Course
     Course code: CSC101
     URL: FC
     Academic Year: 2021
     Faculty: Department of Computer Science
     Assign Lecturer: (there is nothing in the drop-down list.)
     Verify Joining Students: No.


3. Click the "Create Portal" button.




Via Courses:

1. Log in as an instructor at http://121.4.94.30/lrr-testbed 
   
   Username: 202032070221
   Password: aA124536!


2. Go to Courses (http://121.4.94.30/lrr-testbed/Courses.php)


3. Fill in the following information on the right panel - Create new Course Portal.

   
     Course name: Fake Course
     Course code: CSC101
     URL: (can be blank)
     Academic Year: 2021
     Faculty: Department of Computer Science
     Verify Joining Students: No.



Actual Results
--------------

Via Admin:


Result: Got the following SQL insertion error.

Error: INSERT INTO `courses_table`(`Course_Name`, `Academic_Year`, `Faculty`, `Lecturer_User_ID`, `TA_User_ID`, `Course_Code`, `URL`, `Verify_New_Members`) VALUES ('Fake Course','2021','Department of Computer Science','','0','CSC101','FC','0')
Incorrect integer value: '' for column 'Lecturer_User_ID' at row 1



Via Courses:

The new course created successfully.



Expected Results
-----------------

I should be able to create the new course either way (via Admin or via Courses).



Additional Builds and Platforms
--------------------------------

- SQL insertion error relates to Ibrahim's version (lasted modified on 1 April 2021) running on http://121.4.94.30/lrr-testbed

- Duplicate functionality for creating a new course also appears in
the current version of LRR running at http://118.25.96.118/nor

- The instructor has not created any courses before.
Comment 1 IBRAHIM MOHAMED IBRAHIM ISMAIL 2021-10-11 11:00:01 CST 
Interesting, from which page do you usually (as an instructor) create courses? 

Would you consider removing one of the pages as a solution for this issue?

Let me know, I'm interested in this issue.

thanks.

-IBRAHIM
Comment 2 Hui Lan 2021-10-15 20:45:07 CST 
(In reply to IBRAHIM MOHAMED IBRAHIM ISMAIL from comment #1)
> Interesting, from which page do you usually (as an instructor) create
> courses? 
> 
> Would you consider removing one of the pages as a solution for this issue?
> 
> Let me know, I'm interested in this issue.
> 
> thanks.
> 
> -IBRAHIM

I create a new course under this link: http://118.25.96.118/nor/Courses.php
The above link works.

Not under this link: http://118.25.96.118/nor/Admin.php
Because the above link does not work well (I forget the exact problem).

Hui
Comment 3 Hui Lan 2021-11-16 17:59:16 CST 
This bug has been fixed.  For more detail, check the following two links:

- Pull Request: http://121.4.94.30:3000/mrlan/LRR/pulls/26

- Kanban card: http://118.25.96.118/kanboard/?controller=TaskViewController&action=readonly&task_id=1497&token=a412f24019588dcc622e6c2f23d1aa48b2f3a95d833087064a6c1038faba

Hui